razanabbas• 100
@razanabbas
Posted
The design is good overall but I have a few comments:
- The source document was not very satisfying to read. I think you could've done it with less divisions.
- I suggest you add some left padding for list items inside unordered lists.
- I also suggest you add some spacing between table rows.
- Your card is a bit wider than it should be. Try applying a max-width. That's all I personally have to say. I hope you benefit from my feedback.
0
Prateek Saini• 30
@PrateekSaini15
Posted
@razanabbas
Thanks for taking out the time and reviewing my solution. I have done the following as per your suggestions.
-
Add left padding to the unordered list items.
-
Increase the spacing between table rows using padding-top property.
I have following two queries to you.
-
Which part of my source document has more divisions then it should have and could you also suggest how to rewrite that section with less divisions.
-
As for the card width I am already using max-width property with values set to 300px for mobile view and 1000px for desktop view. Please suggest where its more and what value should I have used instead.
0
