Latest comments

• 

  Anjali Dhobale•40

  @DhobaleAnjaliSubmitted almost 2 years ago

  

  QR code component

  2

  70
  

  Martin•540

  @nonso01Posted almost 2 years ago

  • use flex box or grid to super center whatever element you might have, rather than using margin, because no other element can occupy the space.
  • you can check the specified font , because it seems like it's not loading properly.
  • just follow the flow, most mobile are within 360 - 380px wide so you could work on that. Happy coding

  0
• 

  Adebusayo Opeyemi•120

  @Adebusayo0325Submitted almost 2 years ago

  

  Credit card landing page

  #sass/scss

  1

  30
  

  Martin•540

  @nonso01Posted almost 2 years ago

  hey @Opeyemi , it would be amazing if you could work on your styling and adjusting the logics too.

  • it seems like the red border you applied probably for errors remained as the default border.
  • the specified font wasn't applied either
  • you applied a relatively thick box-shadow and encapsulated everything inside a box, instead of occupying the whole page
  • no error boundaries were applied to prevent the user from moving forward if any required field wasn't correct.
  • please try making your code as readable as possible
  • hope you'll rectify all these

  wishing you well, and happy coding

  0
• 

  Sabir Khan•80

  @simplysabirSubmitted over 2 years ago

  

  Social Proof Landing

  2

  20
  

  Martin•540

  @nonso01Posted over 2 years ago

  👋 Hello dude.

  • just some couple of things to review, which might make your solution much more better.
  • for the rating text(s) you forgot to use the appropriate color which was very dark magenta
  • for the mean time I don't have a functional machine, would have made a pull request, the solution looks stretched on larger screens, which means you have to increase your components as well( probably responsively) try using relative sizes (%)
  • doesn't look too good on mobile, with time I know you will do it.
  • and add text-align: center to the card paragraph and other places where needed.

  Hope it helps and hey accessibility issues too nice job though ^_^

  Marked as helpful

  0
• 

  Mounir KHAOUADI•190

  @Mounir-khSubmitted over 2 years ago

  

  QR code Component

  2

  60
  

  Martin•540

  @nonso01Posted over 2 years ago

  • Well looks like you would need to update your styling , and as well make better use of flex box.
  • it will be preferable to wrap the image within a div. and set it sizes to % will adjusting the flex child so as to have a desirable appearance.
  • I might create an issue or pull request in your GitHub too

  Marked as helpful

  0
• 

  Lucas 👾•104,220

  @correlucasSubmitted over 2 years ago

  

  Fylo Data Storage VANILLA CSS (Custom Design + CSS Animations)

  9

  8511
  

  Martin•540

  @nonso01Posted over 2 years ago

  just clean, love the creativity 😁👏

  1
• 

  Okorie Joseph•10

  @scottie130Submitted over 2 years ago

  

  qr-code-component

  1

  30
  

  Martin•540

  @nonso01Posted over 2 years ago

  well there are Soo many errors in your css file right now, that's why some of the contents were not rendered.

  /* this is how you use a variable in css */
  :root{
  --my-var: Bleu;
  --my__var: red;
  --var: yellow;
  
  /* but this is wrong*/
  --my var: orange;
  /* you allowed a space which spoiled everything */
  }
  

  • Try to adjust this few things, and keep pushing 🙂

  0