Skip to content
OverviewSolutions
12
Comments
26
Martin
@nonso01

All comments

  • Anjali Dhobale•40
    @DhobaleAnjaliSubmitted over 1 year ago
    1. I did not understood the exact size for mobile screen
    2. For making a div at center, should I go with flex or margin and transform is okay?
    3. What is the ideal solution for this.

    QR code component

    2
    Martin•460
    @nonso01Posted over 1 year ago
    • use flex box or grid to super center whatever element you might have, rather than using margin, because no other element can occupy the space.
    • you can check the specified font , because it seems like it's not loading properly.
    • just follow the flow, most mobile are within 360 - 380px wide so you could work on that. Happy coding
    0
  • Martin•460
    @nonso01Posted over 1 year ago

    hey @Opeyemi , it would be amazing if you could work on your styling and adjusting the logics too.

    • it seems like the red border you applied probably for errors remained as the default border.
    • the specified font wasn't applied either
    • you applied a relatively thick box-shadow and encapsulated everything inside a box, instead of occupying the whole page
    • no error boundaries were applied to prevent the user from moving forward if any required field wasn't correct.
    • please try making your code as readable as possible
    • hope you'll rectify all these

    wishing you well, and happy coding

    0
  • Martin•460
    @nonso01Posted about 2 years ago

    👋 Hello dude.

    • just some couple of things to review, which might make your solution much more better.
    • for the rating text(s) you forgot to use the appropriate color which was very dark magenta
    • for the mean time I don't have a functional machine, would have made a pull request, the solution looks stretched on larger screens, which means you have to increase your components as well( probably responsively) try using relative sizes (%)
    • doesn't look too good on mobile, with time I know you will do it.
    • and add text-align: center to the card paragraph and other places where needed.

    Hope it helps and hey accessibility issues too nice job though ^_^

    Marked as helpful
    0
  • Mounir KHAOUADI•190
    @Mounir-khSubmitted about 2 years ago

    I need help wrapping content inside the div container. I appreciate your help, Thank you

    QR code Component

    2
    Martin•460
    @nonso01Posted about 2 years ago
    • Well looks like you would need to update your styling , and as well make better use of flex box.
    • it will be preferable to wrap the image within a div. and set it sizes to % will adjusting the flex child so as to have a desirable appearance.
    • I might create an issue or pull request in your GitHub too
    Marked as helpful
    0
  • Lucas 👾•104,340
    @correlucasSubmitted about 2 years ago

    👾 Hello, Frontend Mentor coding community. This is my solution for the Fylo Data Storage Component.

    This challenge was really challenging, was really tricky to create the pop up and position some elements. Was really fun to create the logo and customize the design, I am happy with the design output but not with the code, once I finish the remaining HTML/CSS challenges I'll focus on it!

    🎨 I added some custom features:

    • 👨‍🔬 Custom UI Design + Logo.
    • 🧚‍♀️ CSS Animations

    🍚Follow me in my journey to finish all HTML/CSS only challenges (Only 3 missing)! Gotta Catch ’Em All

    Ill be happy to hear any feedback and advice!

    Fylo Data Storage VANILLA CSS (Custom Design + CSS Animations)

    9
    Martin•460
    @nonso01Posted about 2 years ago

    just clean, love the creativity 😁👏

    1
  • Martin•460
    @nonso01Posted about 2 years ago

    well there are Soo many errors in your css file right now, that's why some of the contents were not rendered.

    /* this is how you use a variable in css */
:root{
--my-var: Bleu;
--my__var: red;
--var: yellow;

/* but this is wrong*/
--my var: orange;
/* you allowed a space which spoiled everything */
}
    • Try to adjust this few things, and keep pushing 🙂
    0
  • Martin•460
    @nonso01Posted about 2 years ago

    Hello Hamza 👏, there is a couple of things to review form your solution.

    Your GitHub repo

    your repository isn't available right now, which hinders me from reviewing some potential mistakes (hope you will resolve that in future).

    Others

    • from what I can see here , you probably failed to import a specified fonts
    import url("google fonts")
/* or @font-face at-rule*/
    • you probably had issues with basic stylings such as box layout
    /*flex box ppt*

    hope you will resolve this and get better, nice job though.

    Marked as helpful
    0
  • Martin•460
    @nonso01Posted over 2 years ago

    well am not sure because from the screenshot and from the page. the blue button download for mac is missing. and the background images as well,there are also missing. you might want to check it out, aside that I think any other thing looks good. nice job

    0
  • Martin•460
    @nonso01Posted over 2 years ago

    well since your hosting provider failed to fetch your solutions I had to look into your source code!. you made use of positioning a lot probably in order to center 🙂!, I started off like that (but with margin:auto). I will advice you to learn flex-box and grid for the time being! it's simple trust me. you can start from here and again try to fix the issues with your hosting providers.

    0
  • Martin•460
    @nonso01Posted over 2 years ago

    hello 👋 dude!

    • you got some html issues, accessibilities and so on, try to write semantic html H1 to Hn.
    • and your solution isn't published completely, try to work on that!.
    • You could look through GitHub documentations or netlify
    • And most importantly take your time and get better no rushing! 😙✌️
    Marked as helpful
    0
  • Martin•460
    @nonso01Posted over 2 years ago

    hmmm!!! 😉👋 hello great solution but you still have some few things to do! your card has some issues with dimensions! not responsive on mobile! the images seems to pop out!

    • you could give it some fixed dimensions or use grid! if you're already in the topic!
    • the applying some media queries! for mobile!
    • great job though 😙✌️
    Marked as helpful
    1
  • Martin•460
    @nonso01Posted over 2 years ago
    • well at first I thought they was no solution.
    • well smooth work there!.
    • and just try and fix some issues (HTML and accessibility) keep up 🦾
    Marked as helpful
    0