@tarek3d
Submitted
What specific areas of your project would you like help with?
Please help in the mobile designe I can't do it write
@mixchex
@tarek3d
Submitted
What specific areas of your project would you like help with?
Please help in the mobile designe I can't do it write
@mixchex
Posted
Hi Tarek3d,
Overall this is a great effort.
Here's some feedback on how you can improve your responsive mobile development:
I hope that helps you a little. Keep on trying new things - there's so much to learn by doing projects like these.
All the best! Mike
Marked as helpful
@CaSmaniotto
Submitted
Apanhei um pouco, mas no final deu certo. Eu acho que o JS poderia melhorar (refactoring).
@mixchex
Posted
Hi Caetano! I like that the form was stopping me from progressing unless certain information was added. For usability, I would suggest to always show the errors as it seems like some errors disappear occasionally. Also, include the id of the form field in the 'for' attribute of the label for greater accessibility. I hope that helps, overall great work! Mike
Marked as helpful
@j3rech0
Submitted
@mixchex
Posted
Hi Jech,
Nice work - this looks good!
One thing to look at is the reports to fix validation and accessibility errors. For class naming conventions, try looking into BEM (Block, Element, Modifier) naming conventions. It's really useful to help with this.
Also, that looks like painstaking work for the icons, but they've come out well.
I hope that helps. Mike
@sundayirvine-code
Submitted
@mixchex
Posted
Hi Irvine,
Nice work on this.
Here are a couple of things to look at:
Also, love that the validation works great on the first page.
Hope that helps you! Mike
Marked as helpful
@huzaifanur
Submitted
Please have a look. All the feed is appreciated be as critical as you can, I will appreciate it.
@mixchex
Posted
Hi @huzaifanur
This looks like a great translation of the design.
Here are some things to look at:
Excellent effort and I look forward to seeing some updates.
Mike
@MD-AHAD-KHAN-PATHAN
Submitted
@mixchex
Posted
Hi Ahad,
Great effort on this challenge.
Looks like there are some accessibility issues with the report on this one that could be fixed such as adding some (landmarks)[https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/landmark_role]. Also, the form seems to allow you to proceed if you only put a phone number in and miss the email and name fields.
Overall it's come out well and you've included a lot of the adjustable details depending on a user's selection, so well done.
I hope this helps you!
Mike
Marked as helpful
@LilithNixx
Submitted
Until this moment, this is the best I can do. I wanted to make the pink background grow while expanding the screen but with no success.
@mixchex
Posted
Hi @LilithNixx,
Currently, your preview site is flagged as dangerous. Not entirely sure why, but something to look into.
In terms of your comments:
background-size:cover
to achieve this.<main>
, <header>
etc) or attributes (role="main"
) onto certain elements throughout your web page to help with accessibility. Find out more about these here.I hope this helps you on your journey in front-end development!
Mike
Marked as helpful
@bramizdev
Submitted
Overlay I didn't know how to create an overlay to an image, this is the approach that I took.
Since this was a link I used a <a>
tag as a container, because I thought when you click at the image it will take you to another page with more details of this NFT.
<a href="#" class="card__url-container">
<img
src="./images/image-equilibrium.jpg"
alt="A transparent cube balanced in one of its corners in a dark blue background promoting balance and calm"
width="604"
height="604"
class="card__img"
/>
<div class="overlay">
<img src="./images/icon-view.svg" alt="" aria-hidden="true" />
</div>
</a>
.card__img {
border-radius: 0.5rem;
}
.card__url-container {
position: relative;
}
.overlay {
position: absolute;
background-color: var(--clr-primary-500);
top: 0;
bottom: 0;
left: 0;
right: 0;
height: 100%;
width: 100%;
display: grid;
place-items: center;
border-radius: 0.5rem;
opacity: 0;
transition: 0.4s ease;
}
.card__url-container:hover .overlay {
opacity: 1;
background-color: var(--clr-primary-500-op);
}
@mixchex
Posted
Hi Brayan,
This looks and feels really nice.
Your approach for the overlay is good. Another alternative could be using the :before
or :after
CSS pseudo-elements for your anchor and positioning it absolutely and making it visible on hover.
Overall it came out really well, so well done.
Hope that helps.
Mike
Marked as helpful
@henrikkudesu
Submitted
I learned that I should avoid manually setting the height of the elements, as it can break the responsiveness of the website. But I had a little problem: there's a big gap between the profile picture and the name that I couldn't figure out how to resolve.
@mixchex
Posted
Hi Leonardo,
This is a great effort and very close to looking just like the design.
That space you've found has been caused by your transform
property.
By using this, the space has been left, but if you use a negative margin-top
it will help move the lower content up at the same time.
I hope this resolves your issue. Great work.
Mike
Marked as helpful
@Joadevy
Submitted
Any feedback would be appreciated! Thanks in advance :)
@mixchex
Posted
Hi Joaquin,
This is really good, well done!
One little user experience related issue working through the form is that the add-ons listed are not very clickable unless you click on the checkbox. It would be very useful for users to have the whole area clickable. An easy way to do this could be to add a <label>
element around the checkbox <input>
instead of a <div>
element.
Great effort!
Marked as helpful
@leonard-ramos27
Submitted
Hello,
This was really challenging and I will highly appreciate any feedback or suggestions especially with the Javascript code. Thank you :)
@mixchex
Posted
Hi Leonard,
Overall this looks really good.
This is definitely a tricky challenge, so you've done a good job!
Mike
Marked as helpful
@blue-crona
Submitted
Hello, this is my attempt at the profile card component challenge.
I'd appreciate any feedback or suggestions that you might have regarding this solution. 😊
@mixchex
Posted
Hey Ben,
Nice work - love the consistency of your card compared to the design.
After having a very quick look at your markup, I suggest you use other elements other than <h1>
and <h2>
tags for your statistics. <h1>
tags should only be used once per page. Elements that may serve better in this instance would potentially be <dl>
,<dt>
, and <dd>
tags. Other than that, I think it came together well for you.
Hope that helps!
Marked as helpful