Results Summary Component (Custom CSS icons)

Community feedback

• 

  Mike Cheshire•410

  @mixchexPosted over 1 year ago

  Hi Jech,

  Nice work - this looks good!

  One thing to look at is the reports to fix validation and accessibility errors. For class naming conventions, try looking into BEM (Block, Element, Modifier) naming conventions. It's really useful to help with this.

  Also, that looks like painstaking work for the icons, but they've come out well.

  I hope that helps. Mike

  0

  ---

  

  Jech•100

  @j3rech0Posted over 1 year ago

  Hi @mixchex,

  Thanks for the comments, I used BEM before and have an idea about the method, on this challenge I am just showcasing the CSS icons :P

  I never intend to correct the accessibility, but I'm aware of that and in real project I do regularly check and use Lighthouse or GTMetrix.

  PS: for structural naming convention I use rscss

  Cheers!

  0

  

  Mike Cheshire•410

  @mixchexPosted over 1 year ago

  @j3rech0 Nice, not heard of rscss, but I did notice the unique prefixed hyphens in your classnames which are clearly that now.

  I like how you're creating another challenge with the addition of the CSS icons.

  Keep it up :)

  1