Profile card component | CSS, BEM

Community feedback

• 

  Mike Cheshire•410

  @mixchexPosted almost 2 years ago

  Hey Ben,

  Nice work - love the consistency of your card compared to the design. After having a very quick look at your markup, I suggest you use other elements other than <h1> and <h2> tags for your statistics. <h1> tags should only be used once per page. Elements that may serve better in this instance would potentially be <dl>,<dt>, and <dd> tags. Other than that, I think it came together well for you.

  Hope that helps!

  Marked as helpful

  1

  ---

  

  Ben•160

  @blue-cronaPosted almost 2 years ago

  Hi @mixchex ,

  Thanks for taking the time to review my solution.

  You've made a great point and appreciate that you've provided alternatives. I've replaced the heading elements with the <dl>, <dt>, and <dd> tags which was good practice.

  0

  

  Mike Cheshire•410

  @mixchexPosted almost 2 years ago

  @blue-crona Great, glad it helped you!

  0