Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Profile card component | CSS, BEM

Ben 160

@blue-crona

Desktop design screenshot for the Profile card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello, this is my attempt at the profile card component challenge.

I'd appreciate any feedback or suggestions that you might have regarding this solution. 😊

Community feedback

@mixchex

Posted

Hey Ben,

Nice work - love the consistency of your card compared to the design. After having a very quick look at your markup, I suggest you use other elements other than <h1> and <h2> tags for your statistics. <h1> tags should only be used once per page. Elements that may serve better in this instance would potentially be <dl>,<dt>, and <dd> tags. Other than that, I think it came together well for you.

Hope that helps!

Marked as helpful

1

Ben 160

@blue-crona

Posted

Hi @mixchex ,

Thanks for taking the time to review my solution.

You've made a great point and appreciate that you've provided alternatives. I've replaced the heading elements with the <dl>, <dt>, and <dd> tags which was good practice.

0

@mixchex

Posted

@blue-crona Great, glad it helped you!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord