All comments

• 

  P

  JJorgeMS13• 250

  @JJorgeMS13

  Submitted about 1 month ago

  What are you most proud of, and what would you do differently next time?

  me encanto poder ocupar CSS grid, podriá cambiar la forma en que lo hago y encontrar mejores practicas.

  What challenges did you encounter, and how did you overcome them?

  el desafio mas grande fue el acomodo de las tarjetas ya que no conozco casi CSS Grid, pero gracias a sus links de la pagina pude entenderlo mucho mejor.

  What specific areas of your project would you like help with?

  Me encantría recibir feedback en como puedo mejor el acomodo de mis tarjetas con CSS Grid.

  

  Tarjetas responsivas creadas con Flexbox y CSS grid.

  1

  10

  

  P

  Max• 160

  @maxkdavis

  Posted about 1 month ago

  Overall your solution looks good and lines up well with the Design. A couple, minor suggestions:

  • Use Semantic HTML as much as possible. Instead of wrapping the header and description in a <div> element consider using the <header> element. I would also wrap the entire title in an <h1> and use the <span> for the bolded 'powered by technology' line.

  • Overall responsiveness is good! I noticed there was some misalignment in the heading when on a mobile breakpoint. Also, the final, desktop breakpoint doesn't occur until the full desktop breakpoint, which leads to a bit of an awkward layout between 400px and 1400px.

  0

  This comment has received 1 replyShow
• 

  Peter Godspower• 470

  @TheBeyonder616

  Submitted about 2 months ago

  What are you most proud of, and what would you do differently next time?

  getting the right size

  What challenges did you encounter, and how did you overcome them?

  getting the right size for the card

  What specific areas of your project would you like help with?

  Any advice would do

  

  responsive card created using Flexbox & Grid

  1

  40

  

  P

  Max• 160

  @maxkdavis

  Posted about 2 months ago

  Overall, really nice work. I like your use of media queries to incorporate responsiveness in your design. The use of CSS variables is a nice practice too.

  Some minor suggestions to consider:

  • the content container's padding isn't aligned to the design, which is causing your h1 heading to not look like the designs.
  • put all your right-side content into one container so that one padding property will align everything. Notice that your 'perfume' text is a bit left of the heading, and your button element is to the right of the pricing text. Ideally, this should have the same vertical left-side alignment.
  • old price text should be smaller. consider the <small> text.

  Hope these help! Again, nice job!

  Marked as helpful

  1

  This comment has received 1 replyShow
• 

  Gabriel.cmd• 220

  @gabriel-m-dev

  Submitted 2 months ago

  What challenges did you encounter, and how did you overcome them?

  many. Especially the tables section. I even left this project unfinished because I couldn't match the boards to the original design. I did my best although I am not satisfied with the final result.

  What specific areas of your project would you like help with?

  table section

  

  Recipe page

  2

  50

  

  P

  Max• 160

  @maxkdavis

  Posted 2 months ago

  Overall, you did an amazing job matching your final solution to the design specs. Could (minor) things I noticed:

  • For the <ul> element, you can adjust the size of the bullet point with the ::marker pseudo-class and 'font-size' property. So you can do something like li::marker { font-size: 12px; }

  • It doesn't appear your project is mobile responsive. You can read more into Media Queries or leverage a CSS Library (i.e., Bootstrap) to add this.

  Nice job and good luck with your continued coding journey!

  Marked as helpful

  0

  This comment has received 1 replyShow
• 

  Savannah Acevedo• 80

  @savvycolleen

  Submitted 3 months ago

  

  Respsonsive Social Links Profile Using CSS Flex, Grid, and BEM

  1

  00

  

  P

  Max• 160

  @maxkdavis

  Posted 3 months ago

  Webpage looks great! I love your use of CSS Variables to more easily assign color to your elements. It looks like your solution is smaller than the design. I would encourage you to dig into Figma to get a better grasp on the various specs and sizes.

  0

  This comment has received 1 replyShow
• 

  tickox• 20

  @tickox

  Submitted 3 months ago

  

  Blog preview card

  1

  20

  

  P

  Max• 160

  @maxkdavis

  Posted 3 months ago

  1.) Try to me more meaningful with the elements you're using to describe the content (semantic HTML). Some examples: • Experiment with the <button> element for the 'learning' text. • Be sure to add an alt attribute to your <img> for accessibility • Experiment with the <small> element to denote text of lesser importance (the published date text) • Main header should always be <h1>. Don't think about it as a sizing thing, but rather semantic and displaying to users (and SEO) which text fields are of most importance

  Marked as helpful

  0

  This comment has received 1 replyShow
• 

  ankushPana• 40

  @ankushPana

  Submitted 3 months ago

  

  Making First QR Scanner Webpage Using CSS And HTML

  3

  20

  

  P

  Max• 160

  @maxkdavis

  Posted 3 months ago

  HTML & CSS

  1. Use the a header element (<h1>) to improve your html semantics.
  2. Size of the component can be changed using the max-width css class. This will help ensure the size of your component matches the design.
  3. Make your code more readable for other users. Removing spacing between lines 35 and 44.

  0