Meet-Landing-Page

Community feedback

• 

  Max•210

  @maxkdavisPosted about 1 month ago

  Really nice job with this challenge! Looks like you matching the design specs quite closely. A couple minor things I noticed, but some of these are more personal opinions/suggestions...

  1.) Create custom variables not just for the color but typography too. For example, the <h1> element: --heading-line-height: 110%; --h1-font-size: 2.5rem; /40px/ --h1-font-weight: 900;

  2.) Be intentful with how you name your element classes. I highly encourage you to dig into the BEM principle. It's a very common naming convention developers use for classes. For example, instead of naming your first image as '.main_img1' I did 'class="hero__img hero__img--mobile"'.

  Hope this helps! And again, great job!

  Marked as helpful

  0

  ---

  

  P

  Arfath•170

  @arfath-aliPosted about 1 month ago

  Thanks for the feedback! I'll work on adding custom typography variables and refining the class naming with BEM. I appreciate the suggestions!@maxkdavis

  0