Design comparison
Solution retrospective
me encanto poder ocupar CSS grid, podriá cambiar la forma en que lo hago y encontrar mejores practicas.
What challenges did you encounter, and how did you overcome them?el desafio mas grande fue el acomodo de las tarjetas ya que no conozco casi CSS Grid, pero gracias a sus links de la pagina pude entenderlo mucho mejor.
What specific areas of your project would you like help with?Me encantría recibir feedback en como puedo mejor el acomodo de mis tarjetas con CSS Grid.
Community feedback
- @maxkdavisPosted 3 months ago
Overall your solution looks good and lines up well with the Design. A couple, minor suggestions:
-
Use Semantic HTML as much as possible. Instead of wrapping the header and description in a <div> element consider using the <header> element. I would also wrap the entire title in an <h1> and use the <span> for the bolded 'powered by technology' line.
-
Overall responsiveness is good! I noticed there was some misalignment in the heading when on a mobile breakpoint. Also, the final, desktop breakpoint doesn't occur until the full desktop breakpoint, which leads to a bit of an awkward layout between 400px and 1400px.
0@JJorgeMS13Posted 3 months ago@maxkdavis muchas gracias por tomarse el tiempo en revisar mi codigo tomaré en cuenta sus sugerencias, gracias
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord