Skip to content
OverviewSolutions
14
Comments
10
Luka
@lukakavtarra

All comments

  • Lorenzo Francoโ€ข480
    @LfrancosSubmitted almost 3 years ago

    Hello everyone! Hope everyone is having fun with the challenges!

    This one was a really good one. I tried to do something a little bit more that was asked by trying to make a different functionality depending if you where on desktop or on mobile. I was able to do it but you needed to refresh the screen every time you resized it. So I found a way to make it work as you resize the window. I'm not sure what I'm doing wrong but it ended up not working. If you look at the script.js file you will see the code that I tried commented. If you can figure out what I'm doing wrong I would really appreciate it :)

    Thank you!!

    Article preview component solution

    2
    Lukaโ€ข320
    @lukakavtarraPosted almost 3 years ago

    thanks for your help it really helped me to solve some of my major problems ๐Ÿ˜๐Ÿ˜

    I've looked up in your code and attribute(footer) class should be contained by landmark ( you should add <footer> tag or you should include attribute class in main tag) that should solve your problem

    I hope it will help you

    Marked as helpful
    0
  • Jitesh Kumar Sahooโ€ข315
    @Jitesh117Submitted almost 3 years ago

    I made the horizontal line (I don't know what to call it) below the London text using border property but I don't think that's the correct way to do it. Can anyone please tell me how to do it?

    profile-card-component-solution

    2
    Lukaโ€ข320
    @lukakavtarraPosted almost 3 years ago

    hey Jitesh , about horizontal line - you can do it 2 ways

    1. you can do it with border-top(like u did it) and set colors and widths or/
    2. you can do it with <hr> ("horizontal rule") and also organize in css (colors and widths)
    Marked as helpful
    1
  • Vasile Cosminโ€ข160
    @VasileCosminSubmitted almost 3 years ago

    Feel free to tell me what i did wrong. Thank you!

    CSS grid

    4
    Lukaโ€ข320
    @lukakavtarraPosted almost 3 years ago

    hey =) looks like text max-width on your solution is more than it's on the given design. i don't see any problems there good work

    Marked as helpful
    0
  • Lukaโ€ข320
    @lukakavtarraPosted almost 3 years ago

    แƒœแƒ˜แƒ™แƒ, แƒกแƒแƒšแƒแƒ›แƒ˜ แƒ แƒแƒ’แƒแƒ แƒช แƒจแƒ”แƒ•แƒฎแƒ”แƒ“แƒ” แƒฅแƒแƒ แƒ—แƒ•แƒ”แƒšแƒ˜ แƒฎแƒแƒ  ๐Ÿ˜Š แƒ›แƒ˜แƒฎแƒแƒ แƒ˜แƒ แƒแƒกแƒ”แƒ— แƒแƒ“แƒ’แƒ˜แƒšแƒ”แƒ‘แƒจแƒ˜ แƒ แƒ แƒฅแƒแƒ แƒ—แƒ•แƒ”แƒšแƒ”แƒ‘แƒก แƒ•แƒฎแƒ”แƒ“แƒแƒ•... แƒกแƒแƒ“แƒ›แƒ” แƒ“แƒแƒ•แƒฃแƒ™แƒแƒ•แƒจแƒ˜แƒ แƒ“แƒ”แƒ— แƒ”แƒ แƒ—แƒ›แƒแƒœแƒ”แƒ—แƒก slack แƒจแƒ˜ แƒ—แƒฃแƒœแƒ“แƒแƒช แƒแƒœ แƒกแƒฎแƒ•แƒ แƒžแƒšแƒแƒขแƒคแƒแƒ แƒ›แƒแƒ–แƒ” แƒ“แƒ แƒ แƒแƒฆแƒแƒชแƒ”แƒ”แƒ‘แƒ˜ แƒ’แƒแƒ•แƒฃแƒ–แƒ˜แƒแƒ แƒแƒ— แƒ”แƒ แƒ—แƒ›แƒแƒœแƒ”แƒ—แƒก.. แƒแƒ› แƒกแƒแƒ˜แƒขแƒ–แƒ” แƒแƒฎแƒแƒšแƒ˜ แƒฎแƒแƒ  แƒ“แƒ accessibility issues แƒ แƒแƒช แƒ’แƒแƒฅแƒ•แƒก แƒจแƒ”แƒ’แƒแƒกแƒฌแƒแƒ แƒ”แƒ‘แƒ˜แƒœแƒ”แƒ‘

    0
  • Lukaโ€ข320
    @lukakavtarraPosted almost 3 years ago

    hello i checked ur code and i have few suggestions for u 1.use at least 1 heading (<h1> tag) 2.use main tag inside body and footer tag those two will solve your accessibility problem 3.try to use chrome's dev-tool it will help you to see design in live while changing the code 4.i rather use px-s and %-s while using width and height 5.after you fix your design add :hover selector its part of the challenge

    you can check my code also if it helps :))

    Marked as helpful
    0
  • Lukaโ€ข320
    @lukakavtarraPosted almost 3 years ago

    Hello Philips i have few suggestions for u

    1. Make sure u'll use at least one heading(h1) in your code it'll solve your accessibility issue
    2. Try to figure out(if you don't know) how to yous :hover Selector :)
    3. & watch out for padding,marging&color situations I'm suggesting chrome's dev-tool for that :)) check out my solutions too and if you have some advices for me i'll be happy to hear
    Marked as helpful
    0
  • Lukaโ€ข320
    @lukakavtarraSubmitted almost 3 years ago

    Check out my grid :)

    Grid

    1
    Lukaโ€ข320
    @lukakavtarraPosted almost 3 years ago

    Can anyone tell me why my button don't work ??

    0
  • Aakash Vermaโ€ข6,710
    @skyv26Submitted 11 months ago

    I tried my best to complete this project, I made it along with my other work and for the first time I made PWA, a first mile-stone towards learning Progressive Web App. Any suggestion, comment will be appreciated. Please check my PWA by installing it on your devices, doesn't matter what you are using (except smart watches, LOL!). I am happy to share that I have completed my all newbie challenges . Please share your experience.

    Ping Coming Soon Responsive + Mobile First + PWA Supported,Vanilla JS

    5
    Lukaโ€ข320
    @lukakavtarraPosted almost 3 years ago

    impressed with your work :)) but if it were a real website it would be more comfortable if links open in a new tab so try target="_blank" in your anchor element ๐Ÿ˜๐Ÿ˜๐Ÿ˜๐Ÿ˜

    Marked as helpful
    1
  • dominiquemcโ€ข90
    @dominiquemcSubmitted almost 3 years ago

    Hi! I would love input on anything I could've changed or improved on.

    I would like insight on the font unit I used for a majority of the styles.css area (REM). I tried to utilize this unit because I've learned that it scales better. For the media query, I used mostly percents and px but I would like information as to what units are best for handling media queries.

    Any other input is welcomed as well!

    Thank you!

    NFT preview card component challenge

    1
    Lukaโ€ข320
    @lukakavtarraPosted almost 3 years ago

    Hey @Domeniquemc , I looked your code and I had same accessibility issues. If you wrap your body content with main tag & footer tag it should solve that issues :))

    Marked as helpful
    1
  • Lukaโ€ข320
    @lukakavtarraPosted almost 3 years ago

    Report shows me 3 accessibility issues ... can someone explain how to solve them?

    0