Skip to content
OverviewSolutions
88
Comments
25

Abhishek choudhary

@dazzlerabhi30800India1,670 points

Namaste! I am a frontend developer from India. There is nothing much to say but I love writing FrontEnd Code and love to learn new , trying new things in Web Dev.

I’m currently learning...

After Learning the basics of Javascript , Now I'm trying to learn and master the react. In Future I have plans after learning the functioning of javascript I will moved to typescript.

Latest solutions

View more solutions

Latest comments

  • Abhishek choudhary•1,670
    @dazzlerabhi30800Posted almost 2 years ago

    Congrats for completing the challenge but the image hasn't been loaded. I think instead of github as beginner try deploying you project on netlify or vercel as it is easier to deploy and they provide a very optimized build. When email format is incorrect it should show a error message you can do it by placing the label tag after input or any other tag to show like input[type="email"]:invalid ~ label { opacity : 1; } and Lastly use link/import tag to to use google fonts instead of including the font file in your project.

    0
  • Abhishek choudhary•1,670
    @dazzlerabhi30800Posted almost 2 years ago

    You could have made only two component: 1: The Main NewsLetter Component 2: Thank you Component That's all you need but still your solution clean btw. You could place them in the separate folder for main and thank you Comp if your using > 2 Components for export And last on clicking the dismiss button the main comp should be visible again.

    Marked as helpful
    0
  • Abhishek choudhary•1,670
    @dazzlerabhi30800Posted about 2 years ago

    Need Feedback to make my solution better.

    0
  • Abhishek choudhary•1,670
    @dazzlerabhi30800Posted over 2 years ago

    for html issues just one level heading at a time like h1, h2 then h3. This will solve the Accessibility issue.

    0
  • Abhishek choudhary•1,670
    @dazzlerabhi30800Posted over 2 years ago

    Congrats on completing the challenge. First Issue I would like to address is instead of giving min-width to body and give it to template qr & second to solve the accessbility issues first wrap the template qr inside main tag and attribute container inside footer tag.

    Marked as helpful
    0
  • Abhishek choudhary•1,670
    @dazzlerabhi30800Posted over 2 years ago

    After writing the email in correct format input should update the state, as it's still showing error.

    Marked as helpful
    0
View more comments