Skip to content
Submitted over 1 year ago

Responsive Newsletter Sign Up using ReactJS and tested MediaQuery Hook

FocusSTmatt•170
@FocusSTmatt
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Newsletter sign-up form with success message
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

  1. Is it best practice to separate Component styles in their own CSS file? if not, what is the proper way of going about this?

  2. I'm not sure if my code is structured properly here. I was practicing passing props and state to components and I think I may have added unnecessary layers of complexity by adding components when it may not have been needed. I'm curious what the textbook code structure would have been for this little app?

Any comments or suggestions are welcome. Thanks!

Community feedback

  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    POINTING CURSOR ↗️:

    • Looks like the component's button element has not a pointer, this property plays a major-role in terms of both UI & UX
    • The cursor: pointer CSS property is important for button-like elements because it changes the cursor from the default arrow to a pointer when hovering over the element. This provides a visual cue to the user that the element is clickable and encourages interaction.
    • In terms of UI/UX, using cursor: pointer helps to improve the usability of the interface by making it easier for users to identify interactive elements. It also helps to provide feedback to the user by indicating which elements are clickable and which are not.
    • So we want to add this property to the following button element
    .submit-btn {
cursor: pointer;
}
    • Now your component's button has got the pointer & you learned about this property as well

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
    0
    FocusSTmatt•170
    @FocusSTmattPosted over 1 year ago

    I appreciate you taking the time to respond. Thanks for the advice!

    0
  • Abhishek choudhary•1,570
    @dazzlerabhi30800Posted over 1 year ago

    You could have made only two component: 1: The Main NewsLetter Component 2: Thank you Component That's all you need but still your solution clean btw. You could place them in the separate folder for main and thank you Comp if your using > 2 Components for export And last on clicking the dismiss button the main comp should be visible again.

    Marked as helpful
    0
    FocusSTmatt•170
    @FocusSTmattPosted over 1 year ago

    Hey Abbishek,

    Thanks for the tips! Your advice is much appreciated!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord