Skip to content
OverviewSolutions
83
Comments
25
Abhishek choudhary
@dazzlerabhi30800

All comments

  • Abhishek choudhary•1,570
    @dazzlerabhi30800Posted over 1 year ago

    Congrats for completing the challenge but the image hasn't been loaded. I think instead of github as beginner try deploying you project on netlify or vercel as it is easier to deploy and they provide a very optimized build. When email format is incorrect it should show a error message you can do it by placing the label tag after input or any other tag to show like input[type="email"]:invalid ~ label { opacity : 1; } and Lastly use link/import tag to to use google fonts instead of including the font file in your project.

    0
  • FocusSTmatt•170
    @FocusSTmattSubmitted over 1 year ago

    1. Is it best practice to separate Component styles in their own CSS file? if not, what is the proper way of going about this?

    2. I'm not sure if my code is structured properly here. I was practicing passing props and state to components and I think I may have added unnecessary layers of complexity by adding components when it may not have been needed. I'm curious what the textbook code structure would have been for this little app?

    Any comments or suggestions are welcome. Thanks!

    Responsive Newsletter Sign Up using ReactJS and tested MediaQuery Hook

    2
    Abhishek choudhary•1,570
    @dazzlerabhi30800Posted over 1 year ago

    You could have made only two component: 1: The Main NewsLetter Component 2: Thank you Component That's all you need but still your solution clean btw. You could place them in the separate folder for main and thank you Comp if your using > 2 Components for export And last on clicking the dismiss button the main comp should be visible again.

    Marked as helpful
    0
  • Abhishek choudhary•1,570
    @dazzlerabhi30800Posted almost 2 years ago

    Need Feedback to make my solution better.

    0
  • Abhishek choudhary•1,570
    @dazzlerabhi30800Posted almost 2 years ago

    for html issues just one level heading at a time like h1, h2 then h3. This will solve the Accessibility issue.

    0
  • Abhishek choudhary•1,570
    @dazzlerabhi30800Posted about 2 years ago

    Congrats on completing the challenge. First Issue I would like to address is instead of giving min-width to body and give it to template qr & second to solve the accessbility issues first wrap the template qr inside main tag and attribute container inside footer tag.

    Marked as helpful
    0
  • Abhishek choudhary•1,570
    @dazzlerabhi30800Posted about 2 years ago

    After writing the email in correct format input should update the state, as it's still showing error.

    Marked as helpful
    0
  • Abhishek choudhary•1,570
    @dazzlerabhi30800Posted about 2 years ago

    First plan the layout of html, then style using CSS. Second if you have problem in designing layout use google. Last after completing the project do it again from scratch.

    0
  • Abhishek choudhary•1,570
    @dazzlerabhi30800Posted about 2 years ago

    Congrats loved your solution😁😁

    0
  • Abhishek choudhary•1,570
    @dazzlerabhi30800Posted about 2 years ago

    you can use onchange property on each input

    0
  • Abhishek choudhary•1,570
    @dazzlerabhi30800Posted about 2 years ago

    Congrats on completing the challenge👌👍. Use Pseudo selector on NFT image and set opacity to 1 while hovering over it.

    0
  • Abhishek choudhary•1,570
    @dazzlerabhi30800Posted about 2 years ago

    center the div using min-height: 100vh; on body tag and use flex property with justify-content: center; and align-items: center;

    Marked as helpful
    1
  • Alba•70
    @albscrSubmitted about 2 years ago

    This is my third challenge and these are some of the problems I faced and I think I didn't solve them as I should have: -I didn't know how to align the three buttons to be horizontally equal (what I did was to modify the margin of each button). -In the last challenge I had problems with making the page responsive, according to me I did it but I received comments that it wasn't. I don't know if in this challenge I made it but I hope your comments about it (I check that it is for the different devices in chrome - inspect). -I eliminated the attribution at the end because I did not know how to position it below (it was on the container and I tried position without success).

    I look forward to your always useful feedback thanks

    Responsive 3-card-column

    2
    Abhishek choudhary•1,570
    @dazzlerabhi30800Posted about 2 years ago

    Congrats!!

    1. Use h1, h2 then h3 to take care of Accessbility Issues
    2. use border: 2px solid transparent; on .btn to fix the design shifting issue on hover! Thank you Namaste🙏
    0