Skip to content
OverviewSolutions
7
Comments
3
Karim
@karimseh

All comments

  • Karim•210
    @karimsehPosted almost 3 years ago

    Hello @MatheusFelixTI , you did really well, your solution is very close to the design, however i have some small observations:

    1. You can delete the button's shadow when it is on :focus, so that it will have a click effect.
    2. You have to catch calculator errors like dividing by zero, etc..

    Thank You 👋

    Marked as helpful
    0
  • Szymon Rojek•4,540
    @SzymonRojekSubmitted almost 4 years ago

    Hi. Please let me know if you have any suggestions - CR.

    • It was a bit tricky to get the best position of the circles svg as a background, maybe is there a better way to do it?

    For this challenge I did:

    • HTML semantic elements;
    • Invisible content just for Screen Reader users;
    • BEM naming;
    • Pseudo-elements for background images and border;
    • SASS;
    • optimal layout for the site depending on device's screen size;

    Thanks! :D

    Profile Card with pseudo elements

    2
    Karim•210
    @karimsehPosted almost 4 years ago

    Hi Szymon,

    I really liked your solution, very clean code, Circles, were also tricky for me, pseudo elements are a great implementation I think, however, I managed to solve it in another way.. don't hesitate to check my solution.

    Happy Coding!

    Karim

    0
  • Karim•210
    @karimsehPosted about 4 years ago

    Hi Mohammed , Nice work it looks great! what i think you should improve is :

    • Hover: links on navbar and arrows buttons (you should also add cursor:pointer to it), and on shop button.
    • in mobile design when clicking on menu , a gray filter should fill all the screen.
    • And Maybe changing the breakpoint of media query to larger one. and please check my solution for this challenge and give me feedback.
    0