@angelveliz1837Submitted 3 months ago
Latest solutions
Latest comments
- @jyoshida93Posted 3 months ago
Hey @angelveliz1837,
Nice job on completing the challenge! I think your solution does a great job of matching the solution on small mobile devices and desktop screens but I have a few suggestions on making it look even better.
-
I would change your media query break point to a larger value. The layout looks good at 375px but at 376px it changes to the desktop layout and everything is a bit squished together.
-
I think it would look good to add a hover effect on the time frame list items. It would make it clear that they can be clicked.
0 -
- @Michael-AlansSubmitted 4 months agoWhat specific areas of your project would you like help with?
I am ready for any feedback
@jyoshida93Posted 3 months agoHey @Michael-Alans,
Great job on completing the challenge! Overall I think your solution does a great job of matching the design. I'm not an expert with react but I did have some general ideas on how you can make your site even better.
- At smaller screen sizes for example 375px you image overflows on the right side. It might be useful to enclose your image in a container.
- Right now your JS only ensures the email field isn't empty. I think it would be good to make sure input string is an email address ie foo@bar.baz. I believe the basic input tag can do this since you set the type="email" in the HTML. You can get if the email field is valid in the JS with something like yourEmailField.validity.valid.
- In your CSS you sometimes use fixed units ie px for properties like padding and margin. To make your site a bit more responsive you can use relative units like rem and em.
1 - @Fbeye04Submitted 3 months agoWhat are you most proud of, and what would you do differently next time?
I successfully completed this project is a proud thing for me because I have left the practice for about 2 months especially I am still learning about javascript and still ask for help from ai
What challenges did you encounter, and how did you overcome them?on the share popup both in mobile and desktop mode it was the hardest thing I had to go through where the results I now get from ai. Therefore, I would like to ask for advice from other friends who saw my project if there is a way for me to better understand javascript without the help of ai as a beginner? depending on ai is very frustrating for me because I feel it is not my own ability.
What specific areas of your project would you like help with?all parts of html and css, if possible I will try to help on the beginner javascript part
@jyoshida93Posted 3 months agoHey @Fbeye04,
Nice job on completing the challenge. I think you solution looks good and your code was well structured and easy to understand. I think something that might make your design look a bit better is using percentages for your card width rather than a fixed rem value. Doing this helps your design adapt to the screen size a bit better than having 1 width for mobile and 1 for desktop.
1 - @riyad-96Submitted 7 months ago@jyoshida93Posted 4 months ago
Hey @riyad-96,
Great job on completing the challenge! Overall you did a great job of matching the design and the site generally looked good on a wide variety of screen sizes. The only issue I noticed was the there was too much vertical space between the sections of Jeanette and Jonathan's testimonies. This seems to happen on screens smaller than 1040px. I'm not sure how you'd solve the issue with grid but I wonder if using flexbox would be simpler than grid since the elements are arranged in a simple column.
0 - @BledanITSubmitted 4 months agoWhat are you most proud of, and what would you do differently next time?
Proud of getting the grid done in much less time than the previous exercise and getting a good idea for the upper colored border.
What challenges did you encounter, and how did you overcome them?Correct sizing, solved easier than the other times
What specific areas of your project would you like help with?I'd like to get feedback on sizes and layout.
@jyoshida93Posted 4 months agoHey @BledanIT,
Nice job completing the challenge! I don't really have much advice to give you your solution looks really good. I really liked the way you used grid to create the cards.
0 - @Sainadh7731Submitted 6 months ago@jyoshida93Posted 4 months ago
Hey @Sainadh7731,
Nice job on completing this challenge.
Your solution does a good job of matching the design on larger screens but I had a few tips that could make your solution even better.
- Media queries could help your layout adapt to the 1 column mobile design.
- Its generally preferred to use relative units like REMs instead of static pixel values for font sizing. REM fonts will scale based on the user's browser font sizing while px sized fonts won't.
0
