@Atomico333Submitted 23 days ago
Latest solutions
Latest comments
- @Fbeye04Posted 16 days ago
hey bro, your project looks solid which in terms of functionality exceeds what I've done. I can't really review the javascript code. However, if I may suggest you can pay more attention to the responsiveness of your project on other screen sizes because I see that on the mobile version the appearance of your project is a little less in accordance with the initial design of the project and on a tablet screen it is not suitable if it looks like a desktop. But overall this is good
Marked as helpful0 - @zahraabelluSubmitted about 1 month ago@Fbeye04Posted about 1 month ago
Great job, you managed to complete this challenge and have tried to make it as requested by the project. What impressed me was that you styled when the cursor was on the activity card, besides that your styling for each part of the card has the same size even when moving between reports (daily, weekly, monthly), and you also tried the json data as requested by the project. But in my opinion, there are other things that you can improve in this project such as:
- Using semantic elements in html code generation to avoid using too many divs. The use of div should be used only as a container for styling. In addition, it will be easier to read the code if you use semantic elements.
- Using the main tag after the body as a wrapper for the main content of web content
- Because you use fetch data, in the html code you just write the card container as a container for other activity cards.
- For styling, try to learn css custom properties to make it easier to use the colors requested by the project in the style guide file
- Use brake units so that your display has a benchmark size and reduces display inconsistencies in various browsers
- Related to number 3, you can directly use the foreach iteration method to create cards so there is no need to rewrite each card in html.
- Try to learn the async/await technique and learn the es6 writing method to make your code more organized
- Learn media queries to make the web responsive on all screen sizes
- Prioritize the work of mobile design first because it is more difficult than desktop design
- On desktop display, all your content is still not centered on the screen so my advice on the body is to add min-height: 100vh
That's all the advice from me that you might be able to use to improve this project, admittedly your styling is better than mine so it only needs a little revision in the code writing section.
Marked as helpful0 - @proAbenezerSubmitted about 2 months ago@Fbeye04Posted about 2 months ago
wow man, your project is really nice it looks neat and the javascript function works well even you also put the user email into the success message (I copied it). Maybe a little suggestion on the 820 px screen size signup form has a white background that is too long and the content is not centered so you can tidy it up. Also, I feel that maybe you need to hover the dismiss message button a bit to give a smoother ui experience.
1 - P@lia-oliveiraSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
It was a very enriching experience. Initially, I thought it would be similar to another card project we worked on, but this one is much more complex because it involves many changes in positioning and the appearance of the share bar. What I learned is reflected in my code.
One thing I wish I had done differently is the layout transition. I’d like the layout change to be less abrupt. I’ll try to improve this in the next project.
What challenges did you encounter, and how did you overcome them?I need to expand my knowledge about responsive images.
What specific areas of your project would you like help with?I’m open to any kind of feedback. If you noticed an area for improvement or something I might have overlooked, feel free to share!
@Fbeye04Posted 3 months agoHi, I've seen your work and I'm amazed that this is the best I've seen from the display that has the size that the project requests, the share button function that runs smoothly and the good code writing. Do you have any suggestions for me on how you can code like you have, how you can customize the look of your project to make it similar to the example, and how you can learn javascript especially as a beginner? I hope you will be pleased with my questions.
1 - @cgojkSubmitted 7 months ago@Fbeye04Posted 6 months ago
hey bro, good job. I've seen your project and was pleasantly surprised that you applied different layouts between mobile and desktop mode and it was great. Here I just want to give some suggestions where I see from the look of your project, you seem to not add enough padding/margin between the picture and the testimonial. Other than that, I would also like to make a suggestion where I think your h1 placement is a bit off where it should be placed in the name section and then h2 should be placed for the testimonials (I know it's not formally appropriate but if you think about it h1 should be something like a title or something important). But the rest is great and I love your work, bravo!
Marked as helpful0 - @radhaBharadwajSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
In this project i used position in css for the first time..
@Fbeye04Posted 6 months agohey bro, good job on the project but I see some things that you might want to add for future projects.
-
pada markup html saya merasa kamu bisa lebih merapikan penulisan dengan membaginya menjadi seperti ini <main class=“main-container”> <div class=“main-description”> .... </div>
<div class=“section-container”> <section class=“section-card” id=“supervisor”>.... </section> <section class=“section-card” id=“supervisor”> .... </section> <section class=“section-card” id=“supervisor”> .... </section> <section class=“section-card” id=“supervisor”> .... </section> </div>
</main> -
use css root to remove the browser's default style so that it is easier for you to style according to your wishes. Then, to make it easier, also try to learn the css custom properties
-
for card layouts instead of using flex I recommend using a grid so that your layout arrangement is easier even for different screen types. Also learn the grid template area that will help you in structuring the layout card. Those are the things that I think you can consider adding or using in future projects. Good job bro!
Marked as helpful0 -
