Skip to content
OverviewSolutions
5
Comments
6
Yassin Amr
@justXeeZ

All comments

  • Yassin Amr•50
    @justXeeZPosted about 4 hours ago

    I'd suggest giving the container a max width like:

    .container{
width: 95%; /*to leave some space for margins */
max-width: 750px; /*change according to your needs */
}
    0
  • frost3dWave•80
    @frost3dWaveSubmitted about 8 hours ago
    What are you most proud of, and what would you do differently next time?
    • starting to get hang of responsive & fluid terminologies and incorporating them naturally.
    • making use of logical properties instead of regular physical ones.
    What challenges did you encounter, and how did you overcome them?

    I had a bit of trouble with using srcset with the img tag & couldn't get my primary image to switch to other image after the specified media query but with the help of the kind folks from the discord server (@AlexKMarshall) I understood the use cases of img and picture element & in the end switched to using picture tag and resolved it.

    What specific areas of your project would you like help with?

    I'd very much like if someone could point out what i could do better in all cases/in much more efficient ways to do things or just in general, things I could improve in my code. But specifically I want help with responsiveness & fluidness of text ect. stuff related to responsive design.

    I'd appreciate any meaningful feedback. Thank you very much!

    Product-preview card component

    1
    Yassin Amr•50
    @justXeeZPosted about 4 hours ago

    solution on point! if you could, please let me how did you get the sizes so right?

    0
  • jedcanchola•120
    @jedcancholaSubmitted 1 day ago
    What challenges did you encounter, and how did you overcome them?

    I faced the challenge to style tables, I was not able to styling as I wanted but it look a lot like the solution, I tried different approaches to styling the table but not able to avoid unexpected behavior while editing the th elements.

    What specific areas of your project would you like help with?

    Styling tables to avoid undesired behavior in this case for desktop design it was not possible for me to add padding to th elements without having td elements moved.

    Also I would like to have advice on how can I handle font sizing to be responsive, how should I handle fonts sizes without using pixels and text to adapt to different sizes.

    Flexbox, Responsive design

    1
    Yassin Amr•50
    @justXeeZPosted about 22 hours ago

    good product, clean code, 10 out of 10

    0
  • Yassin Amr•50
    @justXeeZPosted 1 day ago

    definitely did the assignment but there is a couple of points if you want to perfectly match the design:

    • change the background color.
    • fix the profile name font size.
    • play with the margins till yo find the perfect match for the height.

    other than that, great job :)

    0
  • Yassin Amr•50
    @justXeeZPosted 1 day ago

    Well Written Code!, but the author name could be a bit bigger.

    0
  • Yassin Amr•50
    @justXeeZPosted 1 day ago

    Solution exactly on point, good job.

    0