Frontend Mentor | Jérémy's profile

Devesh•120

@devesht21Submitted over 2 years ago

First try! How is it? What are the mistakes that I should not repeat next time?

QR code component

3

Jérémy•1,020

@jrmydixPosted over 2 years ago

Hi! Well done!

If this can help, I have a suggestion:

Fix accessibility issues: to do so, change your <section class="section-qr"> to <main class="section-qr">.

If you have any questions feel free to ask, I'll try my best to help and answer! 🙂

Marked as helpful

0

Aurelien•10

@Aurelien1997Submitted over 2 years ago

QR-code-component

1

Jérémy•1,020

@jrmydixPosted over 2 years ago

This comment was deleted over 2 years ago

0

Luis José Sanfiel Orsini•10

@Luissanfiel3Submitted over 2 years ago

Responsive design using flexBox

2

Jérémy•1,020

@jrmydixPosted over 2 years ago

Hi! Well done!

If this can help, I have a suggestion:

Fix accessibility issues: to do so, change your <div class="card-title"> to <h1>. For the landmark issue, change <div class="container"> to <main> and change your <div class="attribution"> to <footer>.

If you have any questions feel free to ask, I'll try my best to help and answer! 🙂

1

EkamSinghBrar•30

@EkamSinghBrarSubmitted over 2 years ago

All feedback is Welcome

QR code component

4

Jérémy•1,020

@jrmydixPosted over 2 years ago

Hi! Well done!

If this can help, I have a suggestion:

Fix accessibility issues: to do so, change your <h2> to <h1>. For the landmark issue, change <div class="main-container"> to <main>.

If you have any questions feel free to ask, I'll try my best to help and answer! 🙂

Marked as helpful

0

Salah Amara•40

@amarasalahSubmitted over 2 years ago

QR-code-component-challenge-hub By Salah Amara

1

Jérémy•1,020

@jrmydixPosted over 2 years ago

Hi! Well done!

If this can help, I have a suggestion:

Fix accessibility issues: to do so, change your <h2> to <h1>.

If you have any questions feel free to ask, I'll try my best to help and answer! 🙂

1

Darill•50

@DarilInsanKamilSubmitted over 2 years ago

HTML, CSS

1

Jérémy•1,020

@jrmydixPosted over 2 years ago

Hi! Well done!

If this can help, I have some suggestions:

Fix accessibility issues: to do so, change your <p class="title"> to <h1>. For the landmark issue, change <div class="page"> to <main>.

If you have any questions feel free to ask, I'll try my best to help and answer! 🙂

Marked as helpful

0

kappa•180

@kappa20Submitted over 2 years ago

responsive without using media query instead i mobile first approach and max-width and min-width to prevent the card container from expanding

sass htlm5 css3 grid flexbox res

4

Jérémy•1,020

@jrmydixPosted over 2 years ago

Hi! Well done!

If this can help, I have a suggestion:

Fix accessibility issues: to do so, change your <h3> to <h1>. For the landmark issue, change <div class="container"> to <main> and change your <div class="attribution"> to <footer>

If you have any questions feel free to ask, I'll try my best to help and answer! 🙂

1

cyrus yamir•90

@cyrusyamirSubmitted over 2 years ago

Responsive QR Scanner challenge solution.

2

Jérémy•1,020

@jrmydixPosted over 2 years ago

Hi! Well done!

If this can help, I have a suggestion:

Fix accessibility issues: to do so, change your <h3> to <h1>. For the landmark issue, change <section class="mian-container"> to <main>.
Fix HTML issue: change <img class="qr-code" src="images\image-qr-code.png" alt="image crash"> to <img class="qr-code" src="images/image-qr-code.png" alt="image crash">, don't use backslash in src.

If you have any questions feel free to ask, I'll try my best to help and answer! 🙂

0

Djole-zr•90

@Djole-zrSubmitted over 2 years ago

NFT card

1

Jérémy•1,020

@jrmydixPosted over 2 years ago

Hi! Well done!

If this can help, I have a suggestion:

Fix accessibility issues: to do so, change <div class="attribution"> to <footer>. Then, add <main> after <body> and close it before your <footer>.

If you have any questions feel free to ask, I'll try my best to help and answer! 🙂

Marked as helpful

1