@saadman-galib
Posted
Your design is quite good but something could be better than the previous one. Your QR card is not perfectly centered vertically and you can use the hover effect in the image.
@cyrusyamir
Posted
@saadman-galib thanks I will do
@jrmydix
Posted
Hi! Well done!
If this can help, I have a suggestion:
<h3> to <h1>. For the landmark issue, change <section class="mian-container"> to <main>.<img class="qr-code" src="images\image-qr-code.png" alt="image crash"> to <img class="qr-code" src="images/image-qr-code.png" alt="image crash">, don't use backslash in src.If you have any questions feel free to ask, I'll try my best to help and answer! 🙂
@cyrusyamir
Posted
@jrmydix thanks you! I will do. Can you tell me what is accesbility issues.
I do this in very rush so next time I will follow this don't do these mistakes.
Thanks for guidance and suggestions 😊
@jrmydix
Posted
@ARSHAD023 If you look at your solution page, you can see a "REPORT" section, this is where you'll know what to edit in your code.
Marked as helpful
@cyrusyamir
Posted
@jrmydix thanks for this..😀 i am new to this.
@cyrusyamir
Posted
@jrmydix now I have done that thing you tell to suggest.. suggestion please...
@jrmydix
Posted
@ARSHAD023 Nice! Now you can change this:
<div class="main"> to <main class="main">, and close it with </main> line 78 instead of </div>.alt="image not loaded" to something more explicit, like alt="QR Code".<h3> and </h3> to <h1> and </h1> for accessibility.If you have any other question, I'll try to answer fast 🙂
@cyrusyamir
Posted
@jrmydix ok, I will do. One more thing that after changing in my code design comparison section did not affect, why??
@cyrusyamir
Posted
@jrmydix THANKS....
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
