Responsive QR Scanner challenge solution.

Community feedback

• 

  Md. Saadman Galib Rabbi•140

  @saadman-galibPosted almost 3 years ago

  Your design is quite good but something could be better than the previous one. Your QR card is not perfectly centered vertically and you can use the hover effect in the image.

  0

  ---

  

  cyrus yamir•90

  @cyrusyamirPosted almost 3 years ago

  @saadman-galib thanks I will do

  1
• 

  Jérémy•1,020

  @jrmydixPosted almost 3 years ago

  Hi! Well done!

  If this can help, I have a suggestion:

  • Fix accessibility issues: to do so, change your <h3> to <h1>. For the landmark issue, change <section class="mian-container"> to <main>.
  • Fix HTML issue: change <img class="qr-code" src="images\image-qr-code.png" alt="image crash"> to <img class="qr-code" src="images/image-qr-code.png" alt="image crash">, don't use backslash in src.

  If you have any questions feel free to ask, I'll try my best to help and answer! 🙂

  0

  ---

  

  cyrus yamir•90

  @cyrusyamirPosted almost 3 years ago

  @jrmydix thanks you! I will do. Can you tell me what is accesbility issues.

  I do this in very rush so next time I will follow this don't do these mistakes.

  Thanks for guidance and suggestions 😊

  1

  

  Jérémy•1,020

  @jrmydixPosted almost 3 years ago

  @ARSHAD023 If you look at your solution page, you can see a "REPORT" section, this is where you'll know what to edit in your code.

  Marked as helpful

  1

  

  cyrus yamir•90

  @cyrusyamirPosted almost 3 years ago

  @jrmydix thanks for this..😀 i am new to this.

  0

  

  cyrus yamir•90

  @cyrusyamirPosted almost 3 years ago

  @jrmydix now I have done that thing you tell to suggest.. suggestion please...

  0

  

  Jérémy•1,020

  @jrmydixPosted almost 3 years ago

  @ARSHAD023 Nice! Now you can change this:

  • <div class="main"> to <main class="main">, and close it with </main> line 78 instead of </div>.
  • Line 72: change alt="image not loaded" to something more explicit, like alt="QR Code".
  • Line 74: change <h3> and </h3> to <h1> and </h1> for accessibility.

  If you have any other question, I'll try to answer fast 🙂

  0

  

  cyrus yamir•90

  @cyrusyamirPosted almost 3 years ago

  @jrmydix ok, I will do. One more thing that after changing in my code design comparison section did not affect, why??

  0

  

  cyrus yamir•90

  @cyrusyamirPosted over 2 years ago

  @jrmydix THANKS....

  0