Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component

@EkamSinghBrar

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


All feedback is Welcome

Community feedback

Abdul 8,540

@Samadeen

Posted

Hey!! Cheers 🥂 on completing this challenge.. . Here are my suggestions 1.You should use <main class="container"> instead of <div class="container">. 2. Go down orderly when you are using the headings h1 down to h2 down to h3 and so on.

. Regardless you did amazing.. Happy coding!!!

Marked as helpful

0

@EkamSinghBrar

Posted

@Samadeen Hello!, yes I have been changed now.

0
Danilo Blas 6,300

@Sdann26

Posted

Nice work, Ekam!

I would just tell you to change the div with class="container" to a main and the h2 to an h1 and generate a new report so you don't get errors in your project. Obviously to the h1 you must give the styles that I will tell you to the h2.

Marked as helpful

0
Jérémy 1,020

@jrmydix

Posted

Hi! Well done!

If this can help, I have a suggestion:

  • Fix accessibility issues: to do so, change your <h2> to <h1>. For the landmark issue, change <div class="main-container"> to <main>.

If you have any questions feel free to ask, I'll try my best to help and answer! 🙂

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord