QR code component

Community feedback

• 

  Jaimie Warburton•90

  @FazyyyPosted over 2 years ago

  Not really a criticism but just an option for next time, your parent section with the class "section-qr" seems to only provide the functionality of making the background color full screen. Next time maybe consider applying the background color to the body element and giving it the css attribute of min-height:100vh;

  As others ahve pointed out, using a "main" element rather than a "section" would have been more appropriate.

  Marked as helpful

  0
• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Devesh, I took some time to look at your solution and you did a great job!

  Also add main tag and wrap the card for Accessibility and remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image

  Overall you did well :)

  Hope this help and happy coding!

  Marked as helpful

  0
• 

  Jérémy•1,020

  @jrmydixPosted over 2 years ago

  Hi! Well done!

  If this can help, I have a suggestion:

  • Fix accessibility issues: to do so, change your <section class="section-qr"> to <main class="section-qr">.

  If you have any questions feel free to ask, I'll try my best to help and answer! 🙂

  Marked as helpful

  0