@alisonnbarbosaSubmitted 12 months ago
P
James D
@jdillard2532All comments
- P@jdillard2532Posted 2 months ago
Overall, good job. Just a couple of pointers. The overlay is missing from the navbar on mobile screens. Also the navbar has a weird response when resizing the screen after you click the 'hamburger'. I suggest adding JS that tracks screen size and have the navbar display accordingly. You still did a great job. Keep it up.
0 - @zaighuSubmitted 10 months agoWhat are you most proud of, and what would you do differently next time?
I'm happy that I was able to learn about forms and forms validation. I have written much new JavaScript in it. But I believe I can make it more efficient. So next if I have to make some form I'll try learn more about form and its validation and use more efficient and less JavaScript.
What challenges did you encounter, and how did you overcome them?I didn't knew anything about forms validation. So it was difficult at first but I watch one or two YouTube tutorial, one of the tutorial helped me a lot. Moreover I learnt about forms validation from w3schools and some other websites.
What specific areas of your project would you like help with?issue#1: In the radio button in the form, when I click on the radio or label its gets checked but If I click the button (the parent element of radio and label) it doesn't get checked. I know I need to add something but I don't know what to add.
issue#2: In the same radio button, when it is checked the radio input changes color to green but how do I change the border-color of parent button. Since I can't change something of parent element when child element is checked. I have searched it on google multiple time but it shows me a very complicated way to to change the property of parent element. There is something else which I don't know.
issue#3: The form validation script isn't that efficient I would appreciate it if you can help me with it.
If you can help me with these issues, comment!
P@jdillard2532Posted 3 months agoOverall, good job.
Issue #1 - I suggest a click event listener for the button <button type="button" class="option">. The event listener will listen for a click and select the radio button as well as apply the styles. This kind of helps Issue #2.
Issues #3 - I would use const regex = /^[^\s@]+@[^\s@]+.[^\s@]+$/; This code can be used to validate an email entry. Google "email error handling javascript". Hopefully this helps.
Happy Coding
0 - @gowthamjk08Submitted 3 months agoP@jdillard2532Posted 3 months ago
There are a couple of suggestions. I suggest setting the background width to 100% so that it will cover any width. Another minor suggestion is changing the background color to the pink color. Otherwise, Great Job!
Marked as helpful0 - @muiruri3000Submitted 5 months agoWhat are you most proud of, and what would you do differently next time?
Another Project Done. Adding Web Accessibility to my workflow.
What challenges did you encounter, and how did you overcome them?not much
What specific areas of your project would you like help with?am more conscious about code refactoring now, everytime I finish a project .
- P@Fable54321Submitted 4 months agoWhat challenges did you encounter, and how did you overcome them?
Honestly faced a lot of small issues for different reasons, but it is pretty much what I'm looking for, I am always looking for better ways to do certain things and it is bound to lead to some mistakes.
P@jdillard2532Posted 3 months agoReally Nice Job! I would provide feedback but it looks pretty solid to me.
1 - P@CasperTheChildSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
This time was challenging. It might sound funny or crazy, but I finally learned how to design and write HTML code in a way that avoids problems when writing CSS. However, I faced many issues with CSS, and I encountered even more problems while writing JavaScript. I'll focus on these issues in my future projects. Additionally, I noticed readability issues in both the CSS and JS files. Moreover, most of the technical problems appeared in the main.js file. I should have designed and organized my program better.
What challenges did you encounter, and how did you overcome them?Planning the JavaScript program. I had to change it repeatedly. I should have planned it better from the start. One reason for this is that I kept coming up with new ideas to include in the code, which I hadn't thought of at the beginning.
What specific areas of your project would you like help with?Firstly, I couldn't make the deletion of 'input.Password' toggle the '.CheckBox' and change the 'input[type="range"]'. Secondly, I couldn't remove the button next to 'input.Password' that appears when I mouse over. Lastly, the visual aspect of the 'GenerationButton' is not working properly.
P@jdillard2532Posted 3 months agoOverall, you did a great job. A couple of things I noticed was the hover effect is missing over your slider, copy sign, and generate button. I think your code works against each other since it's generating a code while also allowing you to create your own. If this is the case, I would have a radio button for the user to select whether to generate a random code or create their own. This way you can separate the logic. You are on the right track. Keep It Up!
Marked as helpful1 - @JimztechSubmitted 4 months agoP@jdillard2532Posted 4 months ago
I'm unable to preview your live project. I would love to provide feedback.
0 - @DariaRomanowskaSubmitted 4 months agoP@jdillard2532Posted 4 months ago
Great Job! It looks like you may have forgot the hover effect over the the different sections. However, this is minor. Again, Great Job!
Marked as helpful0 - P@RetroApeSubmitted 4 months agoWhat are you most proud of, and what would you do differently next time?
I like that I managed to make the transition between the two windows smooth, but I don't like that it is not as smooth as I would have liked it to be. Doing things with 'display: none' is a bit finicky.
This is already my current limit. I am happy with what I accomplished.
The different thing that I would do is probably making use of classes to change styles through JavaScript, instead of doing it directly; if it is the correct way, but I will research this next...
What challenges did you encounter, and how did you overcome them?That damn image just doesn't want to behave how I want it to behave. That is, until I put the image inside a div container. The problem might be that the image behaves strangely with flexbox when I want it to scale down in a certain way. Anyway, putting the image in a container makes it possible to use 'max-inline-size' as well as other properties. The container basically contains the image and does not allow it overflow. I used these settings on the image:
#img-main { display: block; height: 100%; max-inline-size: 100%; object-fit: cover; object-position: right; border-radius: 1rem; }Though I am aware that there probably exists a better solution, this is what helped me at the moment.
- @elijahraphael5Submitted 4 months agoWhat are you most proud of, and what would you do differently next time?
finishing the task
What challenges did you encounter, and how did you overcome them?styling was strenous
What specific areas of your project would you like help with?none
P@jdillard2532Posted 4 months agoI would suggest looking at your padding at different screen widths. The live version gets a bit wonky. I also suggest using position absolute for the "Share icons". This will allow you to use "top,left,right,bottom" to position the icon where you would like it. Otherwise, great job! Keep up the good work!
Marked as helpful0 - P@whiteriver-devSubmitted 4 months agoWhat are you most proud of, and what would you do differently next time?
This time I tried using modular CSS. I made a seperate file for variables. I'm happy how it turned out on all screen sizes.
What challenges did you encounter, and how did you overcome them?Scaling the portraits images in proportion to the rest of the elements. I was getting strange results with highly disproportional images as the screen sizes changed.
What specific areas of your project would you like help with?How to make flexible images better?
- @Dadv-a11ySubmitted 4 months agoP@jdillard2532Posted 4 months ago
Great Job. I recommend using flexbox to get the text to line up properly with image. Otherwise, Great Job!
0 - @cga0108Submitted 4 months agoP@jdillard2532Posted 4 months ago
Nice job! It looks like the background color needs to be changed to the light gray color. Other than that, Good Job!
0 - P@Richard1876Submitted 5 months agoWhat specific areas of your project would you like help with?
Plz leave feedback about this Project
- @MichaeldremySubmitted 4 months agoWhat are you most proud of, and what would you do differently next time?
I am proud of getting very close to the design.
What challenges did you encounter, and how did you overcome them?I was struggling to color the `` bullet points but I overcame by learning about the
What specific areas of your project would you like help with?::beforetag. Although I am using that tag, I notice on mobile that when text goes on two lines the second line starts to bleed into the bullet point. I am not sure how to fix this.I used a media query and wrapped a div around the img tag in order to get the image to go across the screen. I applied padding to the wrapped div and then removed the padding when on a smaller screen. Please provide feedback if there is a better way.
I am not super familiar with using local fonts and importing them using
@font-face. I tried to reduce the reuse offont-familybut creating a heading and subheading class with different colors, and font-family.Please provide any other feedback!
- P@jasper2virtualSubmitted 5 months ago
- @minte-atnafuSubmitted 4 months agoP@jdillard2532Posted 4 months ago
Looks great but the background color appears to be different. You should also center your image. Great Work!
0 - @elijahizkielSubmitted 4 months ago
