@geomydasSubmitted 2 months ago
andrean-sihombing
@imandreansAll comments
- @imandreansPosted about 2 months ago
Hello, for this solution you input the wrong links. Please provide the correct link so I can write feedback for you. Thank you!
0 - @1deadjoeSubmitted 2 months agoWhat are you most proud of, and what would you do differently next time?
I am proud that I am getting better at SCSS. It is easier to avoid repitition using mixins, extend, etc.
What challenges did you encounter, and how did you overcome them?I got too focused on the styling that I somehow got lost with the JS. Not being able to follow what class to call was wracking.
What specific areas of your project would you like help with?I would greatly appreciate if someone could help me identiy where to use JS to add the interactivity. I did not know how to place the items in the header in order to get the desired effect.
@imandreansPosted 2 months agoYour solution is already similar to the design, while there are difference like layout and size. You can come back and improve it later.
The solution is responsive, sadly there's no sidebar that appear when I click the menu button.
Your code is well-written both SCSS and HTML. I like that you use picture tag to add the images.
0 - @Perry2004Submitted 3 months ago@imandreansPosted 3 months ago
Your code is well-written and you may improve it by trying to make your code shorter.
For your solution, it's close to the original design.There also an improvement that you can do. Also, don't forget to add interactive element for your design.
Keep Practicing!
0 - @barka-devSubmitted 3 months ago@imandreansPosted 3 months ago
Your solution is closed to the design. Your HTML, CSS, and javascript is well-written and readable. I love how you implement those functions in Javascript, and I learn a lot from your code.
To improve the design, you may set the limit of the bill input to 0 and set your button reset to disabled when the tip amount and total value are zero.
Thus, your code and solution is fascinating and I learn a lot. Keep designing!
Marked as helpful0 - @Dhia-18Submitted 3 months agoWhat are you most proud of, and what would you do differently next time?
I'm mostly proud of my clear and organized JavaScript code. It was really fun working on this project.
What challenges did you encounter, and how did you overcome them?Maybe the only challenge I encountered was in making my JS code shorter and more efficient.
What specific areas of your project would you like help with?I would really appreciate it if someone could take a look at the my code and give me some feedback, as it really helps me improve.
@imandreansPosted 3 months agoYour solution is quite similar to the design. You can experiment more on the size of the cards. For your mobile design is great and you may set the max-width in media query to less than 475px.
For your code is so cleannn. It's well written and readable. You can experiment on it by implementing semantic HTML.
Your code and your design is great! keep learning!
Marked as helpful1 - @Yohannes-GitHubSubmitted 3 months agoWhat specific areas of your project would you like help with?
CSS and JS.
@imandreansPosted 3 months agoYou're solution is close to the design, responsive, and there are a lot of experiment you can do on design, especially interactive and animation.
Your code is well-written and readable. You may improve it by implementing semantic HTML.
Keep it up!
Marked as helpful0 - @ikethedevSubmitted 4 months agoWhat are you most proud of, and what would you do differently next time?
I am proud that I am sharing a finished project for reviewing
What challenges did you encounter, and how did you overcome them?I had a challenge with creating the modal and I can use advice on how to change the color of the share svg image!
What specific areas of your project would you like help with?Css position. I have the hung of things like grid but position, specifically having absolute position scale with responsive design is tricky.
@imandreansPosted 4 months agoYour solution is similar to the design and you may take your time to improve your solution. Your HTML and Javascript is well-written and easy to understand.
About your questions: To change the color of share.svg, you can use 'fill' in css. Refer fill to svg path instead of svg.
You've be able to implement Javascript DOM and other advanced css features. Give your time to learn and experiment and you'll be able to make an identical solution to the design. Keep learning!
0 - @catreedleSubmitted 4 months agoWhat are you most proud of, and what would you do differently next time?
I am proud to have finished this project, especially tackling the grid layout for the desktop interface.
What challenges did you encounter, and how did you overcome them?I struggled to set the last card element like the desktop design, and had to read more about grid and made many attempts.
What specific areas of your project would you like help with?I'm still not sure what to do and how the page should look in between the specified size. Any feedback in general will be appreciated.
@imandreansPosted 4 months agoFantastic, your solution is close to the design. You can do experiment on the font size and padding. Your html and css code is well-structured and can be improved it by pay attention to the readibility of your code.
About your specified size, is it the size of the screen? In my opinion, as long as the design easy to see and successfully show the content to the user on certain size of screen, it is all right. Try to experiment on it. You can do it.
1 - @code269Submitted 4 months agoWhat are you most proud of, and what would you do differently next time?
Organized CSS to the best of my current ability
What challenges did you encounter, and how did you overcome them?Been a while since I've coded, a small difficulty was familiarizing myself with clean code practices and how to manipulate CSS again.
What specific areas of your project would you like help with?I would want tips on how to best write clean code, whether CSS or HTML. I would like to move forward with the learning path using good practices so that I can rebuild the habit of writing clean code for collaboration in the future.
@imandreansPosted 4 months agoYour solution is already similar to the design and you may adjust a little on the font size and padding card. Your code also well-structured and readable both css and html. You've implemented semantic HTML.
Overall, your solution is greatly close to the design and your code is easy to understand.
About your tips on how to write a clean code, try to leave it for a while (a hour or days for example) and come back to read your code. If you don't understand several line, you can change it to become more concise.
Marked as helpful1 - @JamesYcodeSubmitted 4 months agoWhat are you most proud of, and what would you do differently next time?
I am proud of understanding grid layouts.
What challenges did you encounter, and how did you overcome them?A challenge that I encountered during this project was utilizing grid layouts. In order for me to overcome this challenge, I had to research and understand the basics of grid layout systems.
@imandreansPosted 4 months agoThere are differences on text, padding, and element. However, your solution's design is close to the design.
Your code is well-structured and you can improve it by implementing semantic tag html and naming your element with the context of its content.
I'm happy that you are proud to yourself. You've improved your understanding on grid layouts by studying its system.
0 - @SirTebzSubmitted 4 months agoWhat are you most proud of, and what would you do differently next time?
I was able to complete the solution by myself, while giving myself another learning and practicing opportunity
What challenges did you encounter, and how did you overcome them?Not fully replicating the identical solution as illustrated but it taught me to create something of a similar structure and visual representation
What specific areas of your project would you like help with?Resizing of components and content, also dealing with responsive design for multiple displays
@imandreansPosted 4 months agoEven though there are differences in design, the content inside card is close to the design. Your code is well-structured and you can improve your code more by implement semantic HTML.
Great to hear that even though you were able to complete the solution by yourself, you give yourself time to keep practice. Keep improving!
Marked as helpful2 - @kris-lu-devSubmitted 4 months agoWhat challenges did you encounter, and how did you overcome them?
I applied a border-radius to the outer div of the QR code image, but it did not affect the image itself. I found two solutions on Stack Overflow.
1. Outside approach: Set the outer div's overflow property to hidden, which allows the border radius to take effect.
2. Inside approach: Uses the "inherit" value for border-radius on the inner image, enabling it to match the outer div's border radius.
@imandreansPosted 4 months agoYour design is fantastic! it's close to the solution. The code is also well-structured and readable. You might need to included semantic HTML to improve your code. Overall, your design and your code is terrific.
Marked as helpful0
