QR code component

Community feedback

• 

  Dylan de Bruijn•3,230

  @DylandeBruijnPosted 4 months ago

  @kris-lu-dev

  Hiya! 👋

  Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.

  Things I like about your solution 🎉

  • Clear descriptive CSS classes
  • Use of CSS custom properties
  • BEM

  Things you could improve ✍️

  • I suggest adding a bit of padding to your body element so the card has some space around it on smaller viewports.

  • Try using semantic HTML elements like main, section and article.

  • Be careful with setting a fixed width and height on your elements. If the content in these elements grows beyond these restrictions you’ll run into overflow issues. Keeping the height at auto - which block elements are by default - will be fine in most cases.

  • You don’t have to wrap your image in a separate div, it’s possible to style it directly to achieve the same result.

  I hope you find my feedback helpful! 🌟

  Let me know if you have more questions and I'll do my best to answer them. 🙋‍♂️

  Happy coding! 😎

  Marked as helpful

  0
• 

  andrean-sihombing•350

  @imandreansPosted 4 months ago

  Your design is fantastic! it's close to the solution. The code is also well-structured and readable. You might need to included semantic HTML to improve your code. Overall, your design and your code is terrific.

  Marked as helpful

  0