Skip to content
OverviewSolutions
12
Comments
12
Israel Adefidipe
@iadefidipe

All comments

  • Israel Adefidipe•360
    @iadefidipePosted about 3 years ago

    Hi @Oluwajuwonomoyele,

    Great implementation you have here. Just a few improvement I can point out.

    • You should give the desktop view login button a transparent border, so it doesn't shift the layout when it is Hovered
    • In the features section, you should add more space between the section's svg and the details, so they don't begin to overlap
    • Optional: The FAQ section, only one accordion section should be opened at a time, so the layout is a bit tidy
    0
  • Israel Adefidipe•360
    @iadefidipePosted over 3 years ago

    Great work @RodCri! but you have a lot of improvements, I think you could make:

    • You work isnt responsive on smaller screen
    • the faq accordion can be improved on by ensuring once any section of the accordion is opened others are closed, no two sections can be opened at the same time. I think it will make for better user experience
    • You should also work on the last FAQ section Cheers🐱‍👤
    0
  • Israel Adefidipe•360
    @iadefidipePosted over 3 years ago

    Great work @akalizk113! Just two improvements, I think you could make:

    • the placements of the page illustrations is not according to the design specification, or it might be my browser. Your hero section appears not to be not flexed in the desktop view, but the solution screenshot it looks flexed. Maybe you should check your work across different browsers
    • the faq accordion can be improved on by ensuring once any section of the accordion is opened others are closed, no two sections can be opened at the same time. I think it will make for better user experience. Other than that, your implementation appears to be perfect. Cheers🐱‍👤
    Marked as helpful
    1
  • Israel Adefidipe•360
    @iadefidipePosted over 3 years ago

    hi @GhostmaneUrs, your implementation is great. The page overflows on smaller views, you might want to check that, by probably giving the page a max-width. Not really important, but the buttons styles should also have transition time

    0
  • Israel Adefidipe•360
    @iadefidipePosted over 3 years ago

    hi @MartinLundqvist great implementation. Your project only seems to have spacing issues, i feel you can do better with the spacing in the desktop view. The cards are not centered in the mobile view and the header also has some padding issues

    Marked as helpful
    0
  • Israel Adefidipe•360
    @iadefidipePosted over 3 years ago

    Great Implementation! I think you need to fix the mobile view left and right padding, so the elements dont just span across the page as it is now.

    Marked as helpful
    0
  • Israel Adefidipe•360
    @iadefidipePosted almost 4 years ago

    This is great, I love the animations. I am definitely studying your implementation.

    0
  • Israel Adefidipe•360
    @iadefidipePosted almost 4 years ago

    Great job Tom, you might want to work on your font sizes on smaller screens, other than that, you did a very nice job. Also check out the issues flagged by the platform. Keep Learning! cheers

    Marked as helpful
    0
  • Israel Adefidipe•360
    @iadefidipePosted almost 4 years ago

    Great job, your implementation is almost pixel perfect. The platform flagged some accessibility issues, you should check that out. cheers

    0
  • Israel Adefidipe•360
    @iadefidipePosted almost 4 years ago

    Great job.

    • Instead of using ID which should be unique for each element. Use classes, it makes your styling more easy to, and you can use a class for more than one element too

    • the whole card is not well centered on all screens.

    • you should have main container, so you can center the body element. You can also put the text and image section in the container and flex them. See if that helps.

    0
  • Israel Adefidipe•360
    @iadefidipePosted almost 4 years ago

    Looks, great on all screens. But since you have got a style sheet, you dont need the inline styles

    1
  • Israel Adefidipe•360
    @iadefidipePosted about 4 years ago

    You can create media queries for more screen widths and style/position the background for them. Start the mobile background image from the 768px screen width and position it for that width, keep the mobile screen size position. you can position the desktop background Size for 1024px screen width too.

    Your implementation is great, keep coding!

    0