Skip to content
OverviewSolutions
20
Comments
13
P
Hamza H.
@hhamza1

All comments

  • Hamza H.•460
    @hhamza1Posted about 3 years ago

    Very good job. The design is pixel-perfect.

    0
  • Hamza H.•460
    @hhamza1Posted about 3 years ago

    You need to improve the inputs design instead of using the default one.

    Keep up the good work

    0
  • Dean•30
    @XephileSubmitted over 3 years ago

    Order Summary card, responsive from everything between a desktop and a mobile!

    Order Summary HTML/CSS

    2
    Hamza H.•460
    @hhamza1Posted over 3 years ago

    Why do you have an overflow:scroll on the component's content in the mobile version?

    Always avoid setting height property at all cost, you need to have the elements set on the page then start working the layout based on the viewport. You will still need to refactor your code.

    I would suggest you go and check some of the solutions and compare and understand.

    Good job on the effort and keep practicing.

    1
  • Jeffrey•40
    @jgrospe92Submitted over 3 years ago

    Hi everyone,

    I would like to hear some feedback, any suggestions that will help me to improve in coding are highly encouraged. What I have trouble with: I started coding the desktop version first, I struggle with the mobile version. I can't get the small screen to work perfectly. Please take a look at my code and tell me where did I do wrong.

    Best regards Jeff

    Order-summary-desktop first

    2
    Hamza H.•460
    @hhamza1Posted over 3 years ago

    First of all, good job on the delivery.

    Although you started with a desktop approach, you could still have a couple of things to set and you won't have to do much on the mobile view. Setting the display flex on the body would have made your work much easier, also you could have set a max-width to the card, that would have helped also with the responsiveness, box shadow should be fixed, bg-color and pattern could be also fixed.

    You might check my solution for more details : https://www.frontendmentor.io/solutions/order-summary-card-component-with-flex-MHX37axfl

    My approach was mobile-first view. It's much easier to expand to other screen sizes afterwards, not much CSS to write.

    Keep up the good work

    Marked as helpful
    1
  • Hamza H.•460
    @hhamza1Posted over 3 years ago

    Also you need to review your mobile view. Keep up the work

    0
  • Mithat Ucar•90
    @ObjectOrientedMindsetSubmitted over 3 years ago

    This is my first frontend project any feedback will be appreciated.

    CSS Flexbox

    3
    Hamza H.•460
    @hhamza1Posted over 3 years ago

    The mobile-view is not working. Please check that

    Marked as helpful
    0
  • Hamza H.•460
    @hhamza1Posted over 3 years ago

    Hi @rajesh0406,

    For such exercise, maybe going mainstream instead of using libraries and frameworks would be a better practice, so you can be able to improve your basic skills. IMO, the key here is to properly use flexbox, as it would suffice and you'll be able align the card perfectly, also you'll need to fix the padding on the card component left section.

    Keep up the good work.

    Marked as helpful
    1
  • Newton Lomar•75
    @newlomarSubmitted over 3 years ago

    Hey everyone!

    All feedbacks are welcome.

    I would love to get some feedback about:

    • The HTML of my code. Is it fully semantics? Does that h3 tags that I setted inside de li items make sense?

    • I definetely still need to understand flexbox better. I would like a lot about feedbacks on that.

    • I struggled a litle to set de image the way I wanted. That flex-basis property wont let me sleep tonight.

    • Is my use of margin and padding correct? Any recommendation?

    • What about that cover image colour? Is that ok?

    Thank you a lot! Wish you all a great day!

    Mobile-first solution using basic HTML & CSS

    3
    Hamza H.•460
    @hhamza1Posted over 3 years ago

    You did a good work respecting the semantic, I suppose one small thing to review for the card text section is the padding to try to make your work pixel perfect. Keep up the good work and motivation.

    Have a great day

    Marked as helpful
    1
  • Hamza H.•460
    @hhamza1Posted over 3 years ago

    Nice work! One small thing I would suggest is to slow down the accordion animation a little bit, it's too quick.

    1
  • Hamza H.•460
    @hhamza1Posted almost 4 years ago

    Hi Mijail. I loved the animations you added. A slight issue I noticed, when I hover over the elements on the creations section, there is a shaking when opacity changed.

    Great job!

    1
  • Hamza H.•460
    @hhamza1Posted almost 4 years ago

    I would suggest to you to give the button a depth effect when clicked (you can play with box-shadow to figure that out). Keep up the good work!

    0
  • Hamza H.•460
    @hhamza1Posted almost 4 years ago

    @SamyrOR, bro you need to check the preview you posted. It's not working.

    1