Skip to content
OverviewSolutions
6
Comments
6
Dushyant Goyal
@goyal-Dushi

All comments

  • Dushyant Goyal•260
    @goyal-DushiPosted 7 months ago

    Hi , there are few bugs in your application.

    BUG 1 : Multiple countries data coming while viewing single country detail

    Steps to reproduce

    1. Click on any country to view their details
    2. Type in name of another country in the search box and click on search

    Issue : You will see that the country searched for comes above the country initially present in the UI, instead, it should either get replaced with the new search result or you shouldn't have the search box and filter by region while viewing a particular country detail !

    BUG 2 : Neighboring countries not clickable

    1. The neighboring countries are not clickable

    BUG 3 : Region filter goes away on Back click

    After applying region filter, if we select a particular country to view its details and move back using the back button, the previously applied region filter goes away !

    BUG 4: Search result vanishes from UI after blur

    Looks like CSS issue : After typing any country name inside the search result, if we click outside the search box, the typed value goes away from the input field

    Marked as helpful
    0
  • Dushyant Goyal•260
    @goyal-DushiPosted almost 2 years ago

    I really liked your app. Just have few enhancement you could consider.

    1. Try also including Rock paper scissor game in it. So, you can have a switch which can toggle b/w the 2 types of games, the Rock paper & Scissor one , and the bonus one. : )
    2. Have a Reset button so that if someone wants to start a clean game, we could reset the whole progress !
    1
  • Maria Luisa Durães•160
    @MariaLuisaMDSubmitted almost 2 years ago

    In this challenge I had some difficulties with the DOM and hover states, as well as some specific difficulties in the JS. I had to research a lot on how to solve the problems that arose, it took me longer than I expected to finish, but I found a good challenge. Suggestions on design and how to improve are always welcome

    TIP CALCULATOR APP

    1
    Dushyant Goyal•260
    @goyal-DushiPosted almost 2 years ago

    It works well, just few UI tips you can consider :

    1. Give input field some padding from right so that the number input doesn't stick to edges
    2. The label tag used for input field is missing attribute ( for )
    3. The heading spelling : SPL ( I ) TTER not SPL ( Y ) TTER :)

    Also, as a bonus, try saving the input values entered by user in local storage of browser so that on page refresh, the values aren't lost. On reset, you can clear local storage.

    Marked as helpful
    0
  • Dushyant Goyal•260
    @goyal-DushiPosted about 2 years ago

    I think you can work on the logic where you are determining the winner. So, in your code I found that you are using switch case statements to implement the logic. I had rather say there is better way to do that.

    you can check my solution. I have implemented Rock paper scissor game !

    https://github.com/goyal-Dushi/frontend-designs/blob/main/src/pages/RPSgame/components/GameResult.tsx

    Marked as helpful
    0
  • Dushyant Goyal•260
    @goyal-DushiPosted about 2 years ago

    You should use form element for submission of any input value ( present in your HTML validation report) . divs are only used as layout elements. If you don't want to provide any href to a tags, you can use it like this <a role="button" tabindex="0" ...>...</a> or <a href="javascript:void(0);">something</a> or use <span> in case you are unsure of any links to be provided.

    It is good practice and increases accessibility.

    Rest looks fine!

    Marked as helpful
    1
  • Emmanuel Balderas•10
    @EmmanuelBalderasBSubmitted about 2 years ago

    This was a fun one! Any feedback is appreciated and welcomed!

    I couldn't figure out how to only let the user select only one option.

    Interactive rating component

    1
    Dushyant Goyal•260
    @goyal-DushiPosted about 2 years ago

    So, to answer your doubt, you need to maintain a variable state of the button that has been clicked in your clicked function and then, when next time user clicks any button, you need to check if it the same or different button that has been clicked by comparing with the state variable.

    1. if same, then do nothing and return
    2. if different button, the removed all the styling applied to state variable button ( the previous button clicked ) , update the state variable with new button, and apply required styling to new button.

    Also, use ' ./ ' for you image paths, ( relative path ) , so that it can find your images. Currently on website, images aren't loading !

    Marked as helpful
    1