Submitted
@abdraoufx
Looks like a good start. :). I noticed when you resize the browser from desktop to mobile dimensions though the modal off the screen comes shooting up suddenly from left to the top of the screen. The modal itself on mobile just seems a bit off. Great work!
Marked as helpful
@abdraoufx
Posted
@webguy83 Thanks Mate For Your Advice I Really Appreciate Your Words, i'll Try To Fix This Small Problem.
@goyal-Dushi
Posted
I think you can work on the logic where you are determining the winner. So, in your code I found that you are using switch case statements to implement the logic. I had rather say there is better way to do that.
you can check my solution. I have implemented Rock paper scissor game !
https://github.com/goyal-Dushi/frontend-designs/blob/main/src/pages/RPSgame/components/GameResult.tsx
Marked as helpful
@abdraoufx
Posted
@goyal-Dushi Thanks For The Advice, But In Your Situation You Are Handling Only 3 Types Rock, Paper Scissors, In My Situation Iam Handling 5 Types; I Think If I Use IF Else Condition On Those The Code Will Be Harder To Understand, I See That Switch Case Is Better In This Situation To Make The Code More Readable.
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
