@Adithya-CJSubmitted almost 2 years ago
Latest comments
- @godmayhem7Posted almost 2 years ago
Wow your code is really nice 🎉🎉 You put so much efforts in your CSS and that made your code really look beautiful 👌👌. But I noticed that your website isn't responsive on all devices. One of the crucial aspects of being a web developer is ensuring that your website is responsive in all devices. If not your designs would look displaced and it wouldn't be nice, so I would advise you to learn more about media queries in CSS this feature helps you create a well responsive website on all devices. The rest of your code was okay. Hope this feedback was helpful 👍👍
Marked as helpful0 - @TekketsuDevSubmitted almost 2 years ago@godmayhem7Posted almost 2 years ago
Wow your code is really great and well organised for a beginner 🎉🎉 But I kinda noticed something was up with your code. Instead of using just div tags for your entire code try making use of semantic HTML tags like:* header tag: <header></header>, main tag: <main></main>, section tag : <section></section>, nav tag: <nav></nav>, and footer tag: <footer></footer>* This helps other people understand your code correctly And also I noticed some wrong code in your scss file that made your style look off in your CSS I would also advice you to have a better understanding of Flex and Flexbox in CSS The rest of your code was okay. 👌 Hope this feedback was helpful 👍👍
0 - @roleigh1Submitted over 2 years ago@godmayhem7Posted over 2 years ago
hey @roleigh1 your code was cool 👌👌, but you made quite some mistakes in your code javascript especially and you didn't write the correct file path for the icon at the title of your website; it is suppose to be this
<link rel="icon" type="image/png" sizes="32x32" href="favicon-32x32.png">not this<link rel="icon" type="image/png" sizes="32x32" href="./images/favicon-32x32.png">, i always advice people to test their codes for bugs before and after commiting it to their repository this really helps out cause you might be good at programming and coding in general you might have made some mistakes in you code, this action called debugging helps you realise your shortcomings and helps you mend and improve your code, the rest of your code was okay 👌, hope this feedback was helpful1 - @diazlubis19Submitted over 2 years ago@godmayhem7Posted over 2 years ago
nice going @diazlubis19 your code was really nice 👏👏,hear are some tips i think would help out; i went through your code and found out that most of your codes were div-tags and though it may not affect you now but later on its gonna seem like a drag when you are dealing with larger or bigger projects instead of using just div-tags all the time try using other tags in conjunction with div-tags for example:
main-tag: <main></main>, header-tag:<header></header>, nav-tag:<nav></nav>, footer-tag: <footer></footer>, section-tags:<section></section>these tags are self explanatory and they help other people understand your code better,the rest of your code was okay 👌👌, hope this feedback was helpful 👍👍0 - @PChaparroSubmitted over 2 years ago@godmayhem7Posted over 2 years ago
hey @PChaparro your code was absolutely amazing you did well using multiple frame works👏👏, but there was just something you didnt do well i checked out your solution on mobile view i found out that some of your elements was over your button and it made your website look kinda weird, i am sure that you must have forgotten to debug your code judging from the appearance of your website. i always advise people to at least try and debug their codes after committing their files to their repository this helps out in a lot of ways. this is a helpful tool to us as a developer, the rest of your code was okay 👌👌, hope this feedback was helpful 👍👍
1 - @lcabrera13Submitted over 2 years ago@godmayhem7Posted over 2 years ago
@lcabrera13 about the question you asked the answer is yes they are really different, the img-tag(<img>) element is for images that are part of the content, while CSS background images are purely decorative, hope this feedback was helpful 👍👍
1
