I found difficulty in coding a navbar and how to make the content slide down when the dropdown is clicked. I am unsure that whether the way I used media querry is the right way.
Bizzare
@godmayhem7All comments
- @Adithya-CJSubmitted over 1 year ago@godmayhem7Posted over 1 year ago
Wow your code is really nice ππ You put so much efforts in your CSS and that made your code really look beautiful ππ. But I noticed that your website isn't responsive on all devices. One of the crucial aspects of being a web developer is ensuring that your website is responsive in all devices. If not your designs would look displaced and it wouldn't be nice, so I would advise you to learn more about media queries in CSS this feature helps you create a well responsive website on all devices. The rest of your code was okay. Hope this feedback was helpful ππ
Marked as helpful0 - @TekketsuDevSubmitted over 1 year ago@godmayhem7Posted over 1 year ago
Wow your code is really great and well organised for a beginner ππ But I kinda noticed something was up with your code. Instead of using just div tags for your entire code try making use of semantic HTML tags like:* header tag: <header></header>, main tag: <main></main>, section tag : <section></section>, nav tag: <nav></nav>, and footer tag: <footer></footer>* This helps other people understand your code correctly And also I noticed some wrong code in your scss file that made your style look off in your CSS I would also advice you to have a better understanding of Flex and Flexbox in CSS The rest of your code was okay. π Hope this feedback was helpful ππ
0 - @roleigh1Submitted almost 2 years ago
I worked with css grid and position relative to prosition things. on the javascript i used variables to do the calculations but didnt know how to set up the reset but thats why i used a side refresh function.
@godmayhem7Posted almost 2 years agohey @roleigh1 your code was cool ππ, but you made quite some mistakes in your code javascript especially and you didn't write the correct file path for the icon at the title of your website; it is suppose to be this
<link rel="icon" type="image/png" sizes="32x32" href="favicon-32x32.png">
not this<link rel="icon" type="image/png" sizes="32x32" href="./images/favicon-32x32.png">
, i always advice people to test their codes for bugs before and after commiting it to their repository this really helps out cause you might be good at programming and coding in general you might have made some mistakes in you code, this action called debugging helps you realise your shortcomings and helps you mend and improve your code, the rest of your code was okay π, hope this feedback was helpful1 - @diazlubis19Submitted almost 2 years ago
good challenges
@godmayhem7Posted almost 2 years agonice going @diazlubis19 your code was really nice ππ,hear are some tips i think would help out; i went through your code and found out that most of your codes were div-tags and though it may not affect you now but later on its gonna seem like a drag when you are dealing with larger or bigger projects instead of using just div-tags all the time try using other tags in conjunction with div-tags for example:
main-tag: <main></main>, header-tag:<header></header>, nav-tag:<nav></nav>, footer-tag: <footer></footer>, section-tags:<section></section>
these tags are self explanatory and they help other people understand your code better,the rest of your code was okay ππ, hope this feedback was helpful ππ0 - @PChaparroSubmitted almost 2 years ago
It was a little bit difficult to style the images of the hero component, but i think i finally got it. ΒΏAny suggestion / feedback π?
Used technologies:
- Typescript
- React
- CSS modules
- Vite
@godmayhem7Posted almost 2 years agohey @PChaparro your code was absolutely amazing you did well using multiple frame worksππ, but there was just something you didnt do well i checked out your solution on mobile view i found out that some of your elements was over your button and it made your website look kinda weird, i am sure that you must have forgotten to debug your code judging from the appearance of your website. i always advise people to at least try and debug their codes after committing their files to their repository this helps out in a lot of ways. this is a helpful tool to us as a developer, the rest of your code was okay ππ, hope this feedback was helpful ππ
1 - @lcabrera13Submitted almost 2 years ago
Is there a performance difference when using an image using the background-image property or the img tag?
@godmayhem7Posted almost 2 years ago@lcabrera13 about the question you asked the answer is yes they are really different, the img-tag(<img>) element is for images that are part of the content, while CSS background images are purely decorative, hope this feedback was helpful ππ
1 - @lucasdeabrilSubmitted almost 2 years ago
this was a good start for me
@godmayhem7Posted almost 2 years agohey @lucasdeabril your code was absolutely amazing ππ, here are some tips on how to better your code, when i checked out your code i found out that most of your code was wrapped around div-tags and this could really get messy if you are dealing with a larger project, so i think you should try out other tags like section-tags(<section></section>), footer-tag(<footer></footer>),main-tag(<main></main>),nav-tag(<nav></nav>) and header-tag(<header><header>) these tags are self explanatory and they help other people understand your code better, the rest of your code was okay ππ, hope this feed back was helpful ππ
0 - @StirattoSubmitted almost 2 years ago
If you want to test the resolutions, you should know that every time you change the resolution, it reloads the page so that it works correctly.
The email input below can also be sent with Enter.
Next time I'll use toggle() so I don't change so many styles in JavaScript.
Bye!
@godmayhem7Posted almost 2 years agohey @Stiratto your solution was really amazing ππ,here are some feedback to help you better your code; i noticed when i went through your website when i clicked on the answers the icon(angle) it rotated to the top but when i clicked on it again it didn't rotate back and also i tried using mobile view for your website it didn't work out quite well i think that you should have gone through your code before submitting especially the media queries aspect in your css i know that judging from your website that these things are actually things that you forgot, so i will advice you to do some debugging before submitting your code this really helps out because it helps you realize your shortcomings as a web developer,the rest of your code was okayππ, hope this feedback was helpful ππ
0 - @trevisandanielSubmitted almost 2 years ago@godmayhem7Posted almost 2 years ago
hey @trevisandaniel your challenge was totally amazing ππ,here are some tips to help you better your code; when i went through your code i noticed you only used div-tags, using just div tags in your body-tag for your sections look kinda messy try using other interactive tags like section-tags(<section></section>),main-tag(<main></main>),header-tag(<header></header>),nav-tag(<nav></nav>) and footer-tag(<footer></footer>) these tags are self explanatory and they help out when other people are trying to understand your code better, the rest of your code was okayππ, hope this feedback was helpful ππ
Marked as helpful1 - @Kyriacos-StavrinidesSubmitted almost 2 years ago@godmayhem7Posted almost 2 years ago
hey @Kyriacos-Stavrinides i will say your coding skills is not that bad for a beginner. i think you should focus more on html and css check out this free course it emphasis on html and css (https://7r6.com/Html-and-css)and also this was a javascript challenge ,try doing challenges that you know that you can do , hope this feedback was helpful
0 - @imenehaissamSubmitted almost 2 years ago@godmayhem7Posted almost 2 years ago
heyy @imenehaissam your code was amazing πππ,here are some tips on how to better your code ; i noticed in your code the background didn't cover the entire page this is because you didn't set the background for the body, you should have done it like this (body{background:hsl(30, 38%, 92%)}) and also wrapping your entire code just all around div-tags looks kinda messy don't you think try using other interactive tags together with div-tags to make a clean and understandable code like main-tag(<main></main>), nav-tag(<nav></nav>),header-tag(<header></header>),section-tags(<section></section>) and footer-tag(<footer></footer>) these tags are self explanatory and also they make your code cleaner and more understandable. the rest of your code was okayππ . hope this feedback was helpfulππ
0 - @ageddesiSubmitted almost 2 years ago@godmayhem7Posted almost 2 years ago
hey @ageddesi your code was really awesome πππ. here are some tips i have that will help you better your code; i went through your code and noticed that all your layout-sections where just div-tags, wrapping your codes around div-tags looks kinda messy you should try adding other layout-sections like the main-tag(<main></main>),nav-tag(<nav></nav>),section-tags(<section></section>),header-tag(<header></header>) and footer-tag(<footer></footer>). these tags are self explanatory and they help out when someone is trying to understand your code. the rest of your code was okay ππ, hope this feedback was helpful πππ
0