Design comparison
Solution retrospective
It was a little bit difficult to style the images of the hero component, but i think i finally got it. ΒΏAny suggestion / feedback π?
Used technologies:
- Typescript
- React
- CSS modules
- Vite
Community feedback
- @catherineisonlinePosted almost 2 years ago
Looks great. You also might need to add cursor: pointer for your hamburger icon ππ»
2 - @JaneMorozPosted almost 2 years ago
Hey! Your solution to this challenge is great! π
The only thing I've noticed:
- You need to wrap the main content of the page into the <main> tag. It will solve all these landmark issues and improve accessibility.
Keep it up! And good luck π
1 - @godmayhem7Posted almost 2 years ago
hey @PChaparro your code was absolutely amazing you did well using multiple frame worksππ, but there was just something you didnt do well i checked out your solution on mobile view i found out that some of your elements was over your button and it made your website look kinda weird, i am sure that you must have forgotten to debug your code judging from the appearance of your website. i always advise people to at least try and debug their codes after committing their files to their repository this helps out in a lot of ways. this is a helpful tool to us as a developer, the rest of your code was okay ππ, hope this feedback was helpful ππ
1@PChaparroPosted almost 2 years ago@godmayhem7 Thanks for your feedback, I appreciate it. ΒΏCan you tell me the device screen size and the page section (Navbar, hero...) in what you found the problem so I can fix it? I checked the responsive layout with the browser tool and a real device before submit this solution but maybe I missed that one problem π.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord