Grid Testimonial

Community feedback

• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  BODY MEASUREMENTS 📐:

  • The width: 100% property for body element is not necessary. because it's a block level element which will take the full width of the page by default.

  ---

  • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation.

  ---

  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  Bizzare•1,320

  @godmayhem7Posted over 1 year ago

  Wow your code is really great and well organised for a beginner 🎉🎉 But I kinda noticed something was up with your code. Instead of using just div tags for your entire code try making use of semantic HTML tags like:* header tag: <header></header>, main tag: <main></main>, section tag : <section></section>, nav tag: <nav></nav>, and footer tag: <footer></footer>* This helps other people understand your code correctly And also I noticed some wrong code in your scss file that made your style look off in your CSS I would also advice you to have a better understanding of Flex and Flexbox in CSS The rest of your code was okay. 👌 Hope this feedback was helpful 👍👍

  0