Skip to content
OverviewSolutions
4
Comments
20

Abhilashpandey

@freakyjonesindia270 points

i am a front end developer and designer looking for cool design as inspiration and also developing them.......

Latest solutions

Latest comments

  • Abhilashpandey•270
    @freakyjonesPosted over 2 years ago

    Hi Vodina,

    ** congrats on fetching data through API 🎉🎉🎉**

    I just saw your code and here is one suggestion for you. Always handle errors on your API calls

        fetch('https://api.adviceslip.com/advice').then((data) => {
        // console.log(data);
        return data.json();
    }).then((adviceData) => {
        // console.log(adviceData.slip.id);
        document.getElementById('advice-id').innerHTML = adviceData.slip.id;
        // console.log(adviceData.slip.advice);
        document.getElementById('advice-box').innerHTML = adviceData.slip.advice;

    }).catch((err)=>{ 
        console.log("do whatever you want with this error", err)
    })

    Hope this helps, Thanks Happy coding :)

    Marked as helpful
    0
  • Abhilashpandey•270
    @freakyjonesPosted over 2 years ago

    Hi Rimsha congrats on completing the challenge 🎉🎉

    your website looks just like the design. while reviewing your website, one mistake caught my eye, the filter by region dropdown list item cursor is not a pointer.

    Happy coding :)

    1
  • Abhilashpandey•270
    @freakyjonesPosted over 2 years ago

    Hi Fran,

    congratulation on completing the challenge

    I just saw your code and like to give my one suggestion with your permission,

    1. Rather than using media queries throughout your CSS file you can put all your code related to that responsiveness in one place, It will be much cleaner and you have your particular device code in place.
    @media screen and (min-width:950px) {
    img{
        height: 268px;
        width: 268px;
    },
    h1{
        font-size: 21px;
    }
}

    I hope it helps, Thanks. Happy coding :)

    0
  • Abhilashpandey•270
    @freakyjonesPosted over 2 years ago

    Hi Michael,

    congratulation on completing the challenge

    I just saw your code and like to give you one suggestion

    1. instead of using an anchor tag on add cart, a button tag will be a better option for accessibility.

    I hope it helps, Thanks Happy coding :)

    0
  • Abhilashpandey•270
    @freakyjonesPosted over 2 years ago

    Hi Paula,

    congratulation on completing the challenge

    I just saw your code and like to give some suggestions with your permission,

    1. you can add another key to every object in the data.json and then map it for every bar so that you can change the color of the bars.

    2. Start using semantic HTML in your code. Here is a blog for you to get started with semantic HTML. https://www.simplilearn.com/tutorials/html-tutorial/html-semantics

    If you want to know how to do this with only Js you can check out my solution.

    I hope it helps, Thanks happy coding :)

    Marked as helpful
    0
  • Abhilashpandey•270
    @freakyjonesPosted over 2 years ago

    Hello Clewis,

    congratulation on completing the challenge. I just saw your code, Here is my one suggestion that may help you in the future.

    Use of universal operator to get rid of the default browser Style instead of using margin:0, padding:0 for every device

    *{
  margin:0;
  padding:0;
 box-sizing:border-box
}

    I hope it helps, Thanks Happy coding :)

    Marked as helpful
    1
View more comments