Social Proof Section using vanilla CSS and Flexbox.

Community feedback

• 

  Abhilashpandey•270

  @freakyjonesPosted over 2 years ago

  Hello Clewis,

  congratulation on completing the challenge. I just saw your code, Here is my one suggestion that may help you in the future.

  Use of universal operator to get rid of the default browser Style instead of using margin:0, padding:0 for every device

  *{
    margin:0;
    padding:0;
   box-sizing:border-box
  }
  

  I hope it helps, Thanks Happy coding :)

  Marked as helpful

  1

  ---

  

  C Lewis•110

  @casserole27Posted about 2 years ago

  @freakyjones noted! Thank you!

  1
• 

  Eray•1,410

  @ErayBarslanPosted over 2 years ago

  Hey there, nice work with this one! I see you've tried to center your content but you need an addition for it to work:

  html {
      height: 100%;
  }
  
  body {
      ...
      min-height: 100%;
  }
  

  • You should move background-color and image from .body-wrapper to body element. Right now background doesn't cover wide screens. Use the wrapper just to align your content.
  • Also if you use max-width on containers instead of a fixed width, your page becomes more responsive.
  • You have a good usage of media-query, but you might want to increase min-width value as content overflows on certain screens. These are my suggestions to improve your solution, happy coding :)

  Marked as helpful

  1

  ---

  

  C Lewis•110

  @casserole27Posted about 2 years ago

  @ErayBarslan I will look into width and height mins and maxes. I changed the background settings from body-wrapper to body, thank you.

  0
• 

  Adriano•38,410

  @AdrianoEscarabotePosted over 2 years ago

  Hello, how are you?

  Congratulations on the result of your project, it really turned out very good. But try to pay more attention to how the project adapts to different resolutions, both higher and lower.

  On my monitor the project was a little broken, but I managed to solve it as follows:

  body { min-height: 100vh; }

  I also removed the background-color from the body. To not look like the layout is broken.

  the rest is very good hope it helps... 👍

  Marked as helpful

  1

  ---

  

  C Lewis•110

  @casserole27Posted about 2 years ago

  @AdrianoEscarabote I changed the background settings from body-wrapper to body, thank you.

  1