@Spirit2004Submitted 9 months ago
feedbacks are welcomed. I am new to the html and css.
Faisal Alware
@faisalalwareAll comments
- @faisalalwarePosted 9 months ago
Hey @Spirit2004 nice work!
You're design looks nice. I've gone through your solution and i recommend you to align the card in the center of the screen without getting horizontal scroll on the page as per the design. You can achieve it by giving 100vh height and applying flex properties to body. Work on links as its size, border radius, margin and font styling is not as per design. Card padding is too much try to match it as per design. If you don't want to work on footer then remove it its not mandatory, or else style it. Don't keep it as it is provided in template, it doesn't look good.
I hope my suggestion will be helpful for you.
Other than that nice work on design.
Keep Coding.
0 - @iabdwahabSubmitted 9 months ago
I'll be happy if you feedback my solution.
@faisalalwarePosted 9 months agoHey @iabdwahab good job!
You're design looks good and specially the avatar used in the profile pic. I've gone through your solution and i recommend you to apply box sizing, padding and margins as per the design provided in the template.
I hope my suggestion will be helpful for you.
Other than that good job on design.
Keep Coding.
0 - @anuj140Submitted 9 months ago
"I am not confident about my entire CSS code."
@faisalalwarePosted 9 months agoHey @anuj140 nice work!
Your css code looks good, but you should work on font sizing and box sizing as per the design provided in template. You should also add transition to the links on hover & add actual url to the links. You should reduce the padding of the container upto 480px screen size in media query, because at 320px screen size the container is overflowing horizontally.
I hope my suggestion will be helpful for you.
Other than that good job on design.
Keep Coding.
Marked as helpful0 - @Ali-NashSubmitted 9 months ago
help me to improve
@faisalalwarePosted 9 months agoHey there @Ali-Nash.
Good job buddy! Your project looks nice!!
I have a suggestion about your code that might interest you.
You should work on box sizing, font size, mouse hover effect & responsive layout in your code. As compared to the design provided in the template your solution doesn't match completely, as it looks too big in size, no hover effect on links, not box sizing as per design and most importantly no responsive design in mobile view.
I hope this suggestion is useful for you.
Other than that, good job!
Keep Coding
0 - @RaviBeleSubmitted 9 months ago@faisalalwarePosted 9 months ago
Hey Ravi nice work ! you've added your own details in this design that's good, but here is a thing, please try to match the font, font size, box sizing and most important responsive layout as per the design provided in the template. I hope you will take this feedback in a positive manner.
Marked as helpful0 - @AKSHDESAI1Submitted 9 months ago
For responsive purpose, which CSS units do we need to use in website?
either px, vw, vh or any other units and why ?
@faisalalwarePosted 9 months agovh & vw stands for viewport height and viewport width. In this design we apply 100vh to the body so that our card can be in center of the screen and inside the card we use px for height, width and positioning as we are working on the card. You can use css for responsive layout using media query but, I recommend you to use bootstrap flex & grid as it helps you to achieve design faster with less css code.
1
