Design comparison
Solution retrospective
I'll be happy if you feedback my solution.
Community feedback
- @danielmrz-devPosted 10 months ago
Hello @iabdwahab!
Your solution looks great!
I have a suggestion for improvement:
- Use
<main>
to wrap the main content instead of<div>
.
π Tags like
<div>
and<span>
are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page.This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful0 - Use
- @Ezekiel225Posted 10 months ago
Hello there π @iabdwahab.
Good job on completing the challenge !
Your project looks really good!
I have a suggestion about your code that might interest you.
There is an very useful browser extension called Perfect Pixel that allow you compare with the design image and thus see the exact dimensions. I recommend it to you.
I hope this suggestion is useful for future projects.
Other than that, great job!
Happy coding.
0 - @faisalalwarePosted 10 months ago
Hey @iabdwahab good job!
You're design looks good and specially the avatar used in the profile pic. I've gone through your solution and i recommend you to apply box sizing, padding and margins as per the design provided in the template.
I hope my suggestion will be helpful for you.
Other than that good job on design.
Keep Coding.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord