Social links profile

Community feedback

• 

  Daniel 🛸•44,310

  @danielmrz-devPosted 9 months ago

  Hello @Spirit2004!

  Your project looks great!

  I have one suggestion for you to improve it even more:

  • Using margin is not the best option to center an element. Here's a very efficient (and better) way to place an element in the middle of the page both vertically and horizontally:

  📌 Apply this to the body (in order to work properly, don't use position or margins):

  body {
      min-height: 100vh;
      display: flex;  /* it works with grid too  */
      justify-content: center;
      align-items: center;
  }
  

  I hope it helps!

  Other than that, great job!

  Marked as helpful

  0
• 

  Faisal Alware•50

  @faisalalwarePosted 9 months ago

  Hey @Spirit2004 nice work!

  You're design looks nice. I've gone through your solution and i recommend you to align the card in the center of the screen without getting horizontal scroll on the page as per the design. You can achieve it by giving 100vh height and applying flex properties to body. Work on links as its size, border radius, margin and font styling is not as per design. Card padding is too much try to match it as per design. If you don't want to work on footer then remove it its not mandatory, or else style it. Don't keep it as it is provided in template, it doesn't look good.

  I hope my suggestion will be helpful for you.

  Other than that nice work on design.

  Keep Coding.

  0