Skip to content
OverviewSolutions
25
Comments
4
P
Esteban
@evertzner

All comments

  • Esteban•540
    @evertznerPosted over 2 years ago

    Great job! Maybe there are some responsive issues on mobile screen. But you did it great!!

    Nice implementation on your filters, maybe a tip will be to keep status of what you wrote on search field.

    0
  • Esteban•540
    @evertznerPosted over 2 years ago

    Hey, I was taking a look at your solution. And have some points for you to take a look.

    1. Try the countries grid to be more flow with the device size, at 1439px width it collapsed and shows only 1 country.

    2. The solution fails when you click on a country that doesn't have border countries.

    3. Functionality required for the border countries to be clickable is not implemented.

    4. Clicking on the logo should go to the home page, but not change the color theme.

    5. Try to make the filters to be dependant on the other. So If I write a country that is not inside the continent that I select, It won't show anything.

    6. body should keep always the same min-height despite the amount of countries that we filter.

    NOTE: Check the report that is generated in your solution. It shows you that you have a lot of errors and warnings in your html.

    Hope this points help you out on improving your solution!.

    Have a nice weekend!

    Marked as helpful
    0
  • Esteban•540
    @evertznerPosted over 2 years ago

    Wow, awesome job!!! Keep going.

    2
  • Rahimullah•40
    @biqrarSubmitted over 2 years ago

    QR-code card was a challenge for the front-end mentor. I solve it using Bootstrap and custom CSS. you can view and give feedback.

    Responsive QR-code card

    2
    Esteban•540
    @evertznerPosted over 2 years ago

    Hey, I was about to take a look at your solution, but no QR is showing :(

    1