Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

REST Countries API using React with color theme switcher

@alexbelloni

Desktop design screenshot for the REST Countries API with color theme switcher coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
  • API
4advanced
View challenge

Design comparison


SolutionDesign

Community feedback

P
Esteban 410

@evertzner

Posted

Hey, I was taking a look at your solution. And have some points for you to take a look.

  1. Try the countries grid to be more flow with the device size, at 1439px width it collapsed and shows only 1 country.

  2. The solution fails when you click on a country that doesn't have border countries.

  3. Functionality required for the border countries to be clickable is not implemented.

  4. Clicking on the logo should go to the home page, but not change the color theme.

  5. Try to make the filters to be dependant on the other. So If I write a country that is not inside the continent that I select, It won't show anything.

  6. body should keep always the same min-height despite the amount of countries that we filter.

NOTE: Check the report that is generated in your solution. It shows you that you have a lot of errors and warnings in your html.

Hope this points help you out on improving your solution!.

Have a nice weekend!

Marked as helpful

0

@alexbelloni

Posted

@evertzner I have updated my solution with improvements. Thanks for your feedback.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord