REST Countries API using React with color theme switcher
Design comparison
Community feedback
- @evertznerPosted over 2 years ago
Hey, I was taking a look at your solution. And have some points for you to take a look.
-
Try the countries grid to be more flow with the device size, at 1439px width it collapsed and shows only 1 country.
-
The solution fails when you click on a country that doesn't have border countries.
-
Functionality required for the border countries to be clickable is not implemented.
-
Clicking on the logo should go to the home page, but not change the color theme.
-
Try to make the filters to be dependant on the other. So If I write a country that is not inside the continent that I select, It won't show anything.
-
body should keep always the same min-height despite the amount of countries that we filter.
NOTE: Check the report that is generated in your solution. It shows you that you have a lot of errors and warnings in your html.
Hope this points help you out on improving your solution!.
Have a nice weekend!
Marked as helpful0@alexbelloniPosted over 2 years ago@evertzner I have updated my solution with improvements. Thanks for your feedback.
1 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord