Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • Burham B. Soliman• 220

    @egstar

    Posted

    Goodjob so far,

    there were some missing things, you need to lookup for it to make it fully functionally.

    UI:

    • Use the correct colors for keypad at first theme
    • Allow user to switch them upon click as the use would not figure out the drag function
    • use user-select:none at you're CSS to disable text selection

    Functions:

    • Restrict double dotted . numbers, so the number can only get 1 decimal dot to avoid NaN results
    • Fix . key to insert decimal dot into the text as it's only allowed using keyboard
    • Set default value to 0 and make it shown into the calc screen
    • Allow using math functions with the result of the current process, so you can use +,-,* and / with the current result instead of getting result only by =

    that's all what i got for now, goodluck and enjoy your codes.

    0
  • Burham B. Soliman• 220

    @egstar

    Posted

    Good job, You just need to add some missing things, to get the project works as per documents,

    CSS

    • Missing font family with the required font as per documents,
    • Gap between rendered boxes to get the exact result with 4 columns per row,
    • Card height must be sized to 100% of row so the cards might be displayed at the same height / width
    • Country page missing styling as it shows the data without a rendering style
    • Themes must be set for dark/light views

    JS

    • Missing theme switching function.
    • Country borders must be displayed with Names not the alpha3Code and they might be clickable to redirect to the border's page

    any way, good work so far, and Good luck.

    0
  • Burham B. Soliman• 220

    @egstar

    Posted

    Good job so far

    ** Here are some hints to make it better. **

    CSS

    • Keypads inner text needs to be margin top a lil bit
    • Whole Calculator needs to be centered in the screen view
    • use border-bottom instead of box shadow for the buttons shadow
    • Text buttons font should be little smaller

    and rest of works are charming.

    JS

    • You need to display numbers with , after 3 letters, you can achieve it using eval() function

    • Equal button isn't working correctly, you need to fix it so it should work correctly. as it clears the display on press.

    • Default screen should showing always 0 not to be empty

    • You must prevent multi . dots as the number could be floats once, and replace the result with 0. if the left hand of . is empty

    • DEL button must target the last digit of your current screen number, not to reset the whole number as the Reset button does the reset function

    • For the bounce level, you could use localStorage() function to save the current theme so user can get the same Theme after refresh.

    that's all what i got until now, but it was great work btw. Goodluck.

    0
  • Burham B. Soliman• 220

    @egstar

    Posted

    Good job at all, but you could make it better with some more CSS work,

    • make container width 90% to keep some good gap between page borders and the container elements.
    • Image isn't rendering, the resource is not located correctly
    • Missing the " ... " upper menu
    • Boxes radius needs to be more curved
    • Font sizes needs to be more appropriate
    • Alignment of data needs some fixes

    at all nice efforts, and good luck

    Marked as helpful

    0
  • Burham B. Soliman• 220

    @egstar

    Posted

    your answer isn't related to project, please check back and resubmit

    Goodluck

    0
  • Burham B. Soliman• 220

    @egstar

    Posted

    Goodjob overall, but it need to be checked as

    • regExp isn't accurate just try [email protected]
    • try to resize elements , gaps and text line spacing to get the best size
    • mobile screen the dismiss button is so far away, it needs user to scroll empty page to get it
    • email at succes screen must be changed according to entered email..

    Anyway, keep going and good luck

    Marked as helpful

    0
  • Burham B. Soliman• 220

    @egstar

    Posted

    Not bad, but

    • you need to use the assigned colors into style-guide.md
    • you need to make sure of indents and spaces to get the right sizes and perfect shape

    Good work btw and good luck

    1