Design comparison
Solution retrospective
Hello everyone, check out my solution and pass comments on how i can improve. Thanks!
Community feedback
- @Zy8712Posted 12 months ago
Hi there, when testing your site I noticed that it fails even though I typed in a valid email. You should modify your regEX to make sure it passes for valid emails. If you'd like an example of regEX that works feel free to check out mine: link.
Hope you find this useful 👍
Marked as helpful0@LartzmanuelPosted 12 months ago@Zy8712 can I get the email you entered so that i can try it? Because when I enter something like [email protected] it works
0@Zy8712Posted 12 months ago@Lartzmanuel To test your site I just typed random letters followed by @gmail.com. Example:
[email protected]
0@LartzmanuelPosted 12 months ago@Zy8712 you were right! My regEx was inaccurate. I have made the changes now. Try it again! Thanks for helping!
Can I get your socials so we can talk more?
0 - @egstarPosted 12 months ago
Goodjob overall, but it need to be checked as
- regExp isn't accurate just try [email protected]
- try to resize elements , gaps and text line spacing to get the best size
- mobile screen the dismiss button is so far away, it needs user to scroll empty page to get it
- email at succes screen must be changed according to entered email..
Anyway, keep going and good luck
Marked as helpful0@LartzmanuelPosted 12 months ago@egstar when I tried [email protected] it was rendered invalid. Kindly try it again I'd also work on the dismiss button for mobile screen and also I'd also correct the email at the success screen. Thanks a lot!
0@egstarPosted 12 months ago@Lartzmanuel as long as [email protected] is a valid email it might bot be appears as invalid, Good job so far btw,
here a part of regExp that could treat the emails right,
let checkEmail = RegExp(/^.+@[A-Za-z0-9\-]+(\.[A-Za-z]{1,}){1,}$/g)
give it a try, and try other emails like @domain.co.uk or @domain.us or even @domain.info or @sub.domain.com as all of above is still valid mails Goodluck
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord