All comments

• 

  Den Mark•50

  @devmorkSubmitted about 2 months ago

  What are you most proud of, and what would you do differently next time?

  What I'm proud of is that I completed this project using only the knowledge I currently have without the help of AI. For my next challenge I will be careful in deciding what tags to use in order to have a readable and structured html code.

  What challenges did you encounter, and how did you overcome them?

  There's not much challenge I counter during making the project. I only forgot the tags and how to use them since I stop learning front end for a year. Before I take the challenge I did some reading in w3schools and watch tutorials in YouTube to refresh.

  What specific areas of your project would you like help with?

  • Using flexbox property
  • Proper usage of flexbox property
  • Proper usage of html tags

  

  QR Code Component using HTML and CSS

  2

  30
  

  Kostya D.•20

  @dvgldevPosted about 2 months ago

  It seems to me that the box shadow is different from the one in the layout, but the work is excellent, there is nothing to complain about. Probably the author added his own twist ;)

  0
• 

  willprince•40

  @willprinceSubmitted about 2 months ago

  What are you most proud of, and what would you do differently next time?

  I have done it quickly but I don't know if I used the correct HTML semantic or if I named mthe class correctly.

  What challenges did you encounter, and how did you overcome them?

  I was not sure how to use typography inside my style.css. Do I have to create class that contain the typo or should I style the specific element. For exemple shoud I style my or use a class? What is the best practice?

  What specific areas of your project would you like help with?

  Sementic and style.css design system best practice. I want to know what is the best pratice.

  

  QrCode Card

  2

  30
  

  Kostya D.•20

  @dvgldevPosted about 2 months ago

  Looks great!

  1
• 

  4rd2•60

  @4rd2Submitted about 2 months ago

  What are you most proud of, and what would you do differently next time?

  I am most proud of being able to get flexbox to work properly. If I had to do this differently next time I would start with centering.

  What challenges did you encounter, and how did you overcome them?

  I had a lot of challenges with how to properly start the whole project. After an hour of cluelessness I decided to come back to the project and was able to get a start in.

  What specific areas of your project would you like help with?

  I wasn't sure how to do mobile and desktop sizing. I also had trouble understanding if I was supposed to use exact measurements or use some other kind of method.

  

  QR-code

  2

  20
  

  Kostya D.•20

  @dvgldevPosted about 2 months ago

  Well, lets see. You probably forgot to change the font of the text, for this job it was enough to add a line to the body, since there is only one font.

  font-family: 'Outfit', serif;

  html, body {
      height: 100%;
      background-color: hsl(212, 45%, 89%);
      display: flex;
      justify-content: center;
      align-items: center;
  }
  

  Also, you didn't set the pixel dimensions for the container and it's much different from the dimensions in the layout.

  <div id="container">

  width: 320px;
  height: 499px;
  

  The same with the image, but here you indicated the size, but it is not correct.

  <img src="images/image-qr-code.png" alt="qr-code">

  width: 288px;
  height: 288px;
  

  I would also advise you not to use ID when you are not working with JavaScript for example. It is better to use classes, because it can get confusing.

  Not bad for a start, I really hope to see your work in the future with progress. With love from Ukraine ;)

  0