Skip to content
Submitted 2 months ago

QR-code

4rd2•60
@4rd2
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I am most proud of being able to get flexbox to work properly. If I had to do this differently next time I would start with centering.

What challenges did you encounter, and how did you overcome them?

I had a lot of challenges with how to properly start the whole project. After an hour of cluelessness I decided to come back to the project and was able to get a start in.

What specific areas of your project would you like help with?

I wasn't sure how to do mobile and desktop sizing. I also had trouble understanding if I was supposed to use exact measurements or use some other kind of method.

Community feedback

  • Kostya D.•20
    @dvgldevPosted 2 months ago

    Well, lets see. You probably forgot to change the font of the text, for this job it was enough to add a line to the body, since there is only one font.

    font-family: 'Outfit', serif;

    html, body {
    height: 100%;
    background-color: hsl(212, 45%, 89%);
    display: flex;
    justify-content: center;
    align-items: center;
}

    Also, you didn't set the pixel dimensions for the container and it's much different from the dimensions in the layout.

    <div id="container">

    width: 320px;
height: 499px;

    The same with the image, but here you indicated the size, but it is not correct.

    <img src="images/image-qr-code.png" alt="qr-code">

    width: 288px;
height: 288px;

    I would also advise you not to use ID when you are not working with JavaScript for example. It is better to use classes, because it can get confusing.

    Not bad for a start, I really hope to see your work in the future with progress. With love from Ukraine ;)

    0
  • bedende•80
    @bedendePosted 2 months ago

    Basically exactly like the solution, impressive!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord