@chilldeleuze
@Ttyn08
Submitted
What are you most proud of, and what would you do differently next time?
Bạn tự hào nhất về việc đây là dự án tôi làm nhanh nhất.
What challenges did you encounter, and how did you overcome them?
không có
What specific areas of your project would you like help with?
Tôi muốn các bạn nhận xét về việc sử dụng nguyên tắc BEM và các semantic đã chính xác hay chưa?
@chilldeleuze
Posted
Good job, you nailed the design.
There's a small issue with the buttons though: They would only work if the user clicks directly on the text. A click anywhere else on the buttons wouldn't open the link. You might want to get rid of the <div class="box-social"> and instead rely only on the <a>.
It seems like you used BEM, or some variant. Maybe try to use double dashes between block and element, so the code is a little more readable (e.g. .box--profile. I also think leaving an empty space between the css-selector and the opening curly brace is a good idea, since it increases readability.
Marked as helpful
What are you most proud of, and what would you do differently next time?
This project was the first time where I used the CSS clamp() function. I've been doing CSS for years but never thought of its use cases, until the instructions of this challenge asked to find a way to make responsive fonts without media queries!
I'm also learning about code design patterns. Although I had the option to hard code styles for each element, I created reusable styles for each font from the provided style guide. My HTML ended up having both utility classes as well as semantic classes to be targeted in the CSS. Is this an acceptable practice?
@chilldeleuze
Posted
I like how clean your html code looks, aswell as the solution using clamp()
I think mixing in some utility classes to handle typography is perfectly sensible.
@Lilian4441
Submitted
What are you most proud of, and what would you do differently next time?
Definitely most proud of figuring out how to use flexbox and grid together to format everything the way I needed it (proper spacing and margins). I think next time I'd more thoroughly investigate efficient ways to solve a problem like this. I spent too much time trying to figure out how to code this without using a flexbox and grid.
What challenges did you encounter, and how did you overcome them?
Biggest challenge had to have been justifying/aligning the content properly. I didn't have a ton of knowledge beyond base HTML/CSS, and it turned out to be way easier than I thought! I originally tried just experimenting with functions I was familiar with, but then ended up looking on Google for resources I could use to show me how to properly utilize a flexbox to position the elements the way I wanted them.
What specific areas of your project would you like help with?
I think efficiency of my code is the biggest one. For example, I think my CSS Stylesheet is very oversaturated, and was wondering if there were changes that could be made to my HTML and CSS files to make it less overwhelming but still have the same effect as I have now.
@chilldeleuze
Posted
Good job, I think!
I have a few suggestions: I saw you're not using <p>- or <h>-Tags for your text and headers. You probably should, as this gives everything more structure.
Also maybe try to look if there's a way for to separate styling of text from more general layout questions. E.g. you are currently setting the same font-family three times. You could instead do something like this, which sets the font-family for your entire document:
body {
font-family: Outfit;
}
You should also put some padding on .flex-container-text. This way you don't need to set all these margins for .qr-header and .qr-body.