SocialLinksProfile

Community feedback

• 

  chilldeleuze•80

  @chilldeleuzePosted about 1 month ago

  Good job, you nailed the design.

  There's a small issue with the buttons though: They would only work if the user clicks directly on the text. A click anywhere else on the buttons wouldn't open the link. You might want to get rid of the <div class="box-social"> and instead rely only on the <a>.

  It seems like you used BEM, or some variant. Maybe try to use double dashes between block and element, so the code is a little more readable (e.g. .box--profile. I also think leaving an empty space between the css-selector and the opening curly brace is a good idea, since it increases readability.

  Marked as helpful

  0
• 

  Adriano•38,310

  @AdrianoEscarabotePosted about 1 month ago

  Hey Tran Thi Yen Nhi, how’s it going? I was really impressed with your project’s result, though I have some advice that could be helpful:

  Consider using rem for font sizes. When font sizes are set in absolute units like pixels, users can't adjust the text size based on their preferences. Relative units like rem adapt to the screen size and user settings, making them more flexible across various devices.

  If you'd rather keep using px, you can download a handy VS Code extension that converts pixels to rem automatically

  link -> px to rem

  Since this project is only based on a single page component, there is no need for a h1 tag. It's always a good idea to prevent accessibility errors, so I believe it would be beneficial for you to add a "h1" in this component. Don't worry if you forget about "h1," though; it's a good practice for when you are developing larger sites.

  <h1>Welcome to Social links profile</h1>
  

  Everything else looks great.

  Hope this helps! 👍

  0