@Hlm19966Submitted about 1 month ago
Lorena Castillo Goche
@cas1092All comments
- @iyinoluwaboluwatifeSubmitted about 1 month ago@cas1092Posted about 1 month ago
looks good!, mine also had the same desing flaw, but other than that i think it works great!
0 - P@marcello88cSubmitted about 1 month ago
- @Dadv-a11ySubmitted about 1 month ago@cas1092Posted about 1 month ago
i think you should keep your style in a separate file
Marked as helpful0 - @Tonny-Blair-DanielSubmitted about 2 months ago@cas1092Posted about 2 months ago
Great work! maybe you should review the design, i also got the same trouble at centering the card (in all the challenges almost)
0 - @razanabbasSubmitted about 2 months agoWhat are you most proud of, and what would you do differently next time?
I am proud that I could implement interactivity into this project
What challenges did you encounter, and how did you overcome them?I found this project to be more challenging than the previous ones and I had this problem where the event listeners on my buttons where not working, but after hours of guessing I found out it was due to using z-index: -1 which made my buttons unclickable. So I had to remove it but the design did not turn out the way I wanted it to be.
What specific areas of your project would you like help with?Can someone please tell me how can I improve my grid for the desktop design (in the media query)? I want the first column to span the whole two rows but that is not happening.
@cas1092Posted about 2 months agoit look's good to me, i think i suffer way to much on the challenge to give advise on all the functionality.
about your grid problem, i think you should use
grid-row: 1 / span 2;on profile0 - @hannerrSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
I enjoyed working on a project and seeing results
@cas1092Posted 7 months agoGreat solution!, we both had difficulties on showing the validation message, so for that part i can't help. On the parts i can give advice it's to separate the files .css .js for better understandig. In your screenshot i can't see the image, but in the live site it's ok Maybe you have to work a little bit on the dessign, you card it's too large.
0 - @dirkvankriekenSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
I'm proud that it all works as supposed and it closely matches the designs. Next time I will try to think it through more before starting to write the code. This time I just tried to make it work without having much of a plan how to make it work.
@cas1092Posted 7 months agoyour's look better than mine, i think you just miss the change on the color of the bottom on the desktop page...
0 - @faaazySubmitted 7 months ago@cas1092Posted 7 months ago
i can't see your github but i presume you don't have margins on the body or main. and some of you content cards are not in the rigth place.... other than that... i believe you made it.
0 - @JimztechSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
The application of css grid to this project.
What challenges did you encounter, and how did you overcome them?My problem was figuring out how to use css grid in spanning elements across multiple rows. I got a lot of help from moderators on the discord channel
@cas1092Posted 7 months agobesides the obvious design challenges i think it works very clearly
Marked as helpful0 - @jolman009Submitted 7 months ago@cas1092Posted 7 months ago
i think you put too much padding on the container, and the color it's wrong. on the other hand i think your's it's better than mine!
0 - @popcorn150Submitted 7 months agoWhat are you most proud of, and what would you do differently next time?
Well, one thing I'm proud of is that I have been doing this since the first challenge so I already know where I was headed, that way it wasn't hard to handle. Also I want to give a quick thanks to the developers that helped me with my last solution on flexbox (@MohammadSoleimanikia and @mahbt) I didn't have an issue using flex-box this time due to your suggestions on my previous project and it saved me a lot of build time :)
What challenges did you encounter, and how did you overcome them?For my challenges on this project, I had issue making each buttons seat on their own line.. I was using flex but they were all seating close to each other.
How'd I overcame this? Well I opened my chrome developer's tool to mess around with the display positioning a little, I was trying out different options then when I tried 'Grid' it worked perfectly.
So instead of [display: flex] I did [display: grid] and it worked perfectly for me! :)
What specific areas of your project would you like help with?Any is fine, more tips and tricks to make build faster is highly appreciated thank you. :)
@cas1092Posted 7 months agooverall the design is correct, aparently we both had issues with the sizing (your's too small, mine too big), maybe add some padding to your card i fell it's a little 'skynny'.
Sorry for the slim feddback but i'm very junior on this
Marked as helpful1 - @zacarias39Submitted 7 months agoWhat are you most proud of, and what would you do differently next time?
I'm proud because I manage to complete. I would do it with flexbox instead.
What challenges did you encounter, and how did you overcome them?The one that took my time was to align the name with the profile picture. I set the vertical-align to middle, that kind of solved my issue.
What specific areas of your project would you like help with?I need help making those challenges pretty responsive.
@cas1092Posted 7 months ago-The background-color of the card is off -the border-radius attribute on the learning item isn't visible, i put it just what the figma document said (4px maybe). -i also just learn about the flexbox... it's so much easy!
-by looking at you solution i remember i forgot the border on my solution
Marked as helpful0 - @Jyoti-shinde-coderSubmitted 7 months ago@cas1092Posted 7 months ago
The solution doesn't fit the exactly criteria, the font and the shadow are the most obvious places to look. probably the first line on the style, when it set ups 'Segoe' font overrides the line 18, where it does call for the solicited font in the design. about the corners, it felt short to the correct mesure, and it forgot to also give some radio to the img
0
