Hey all. I decided to do this one in React as I'm going to add some more animations tomorrow, like when content is visible it will fade in. I used framer-motion for animating the landing section.
Ahnaf Hasan Shifat
@ah-nafAll comments
- @sean-b765Submitted over 3 years ago
- @softmagnetSubmitted over 3 years ago
Hi every one, this is my very first challenge on frontend mentor. It is written with sass. I am also a beginner with sass, would be very grateful if someone points out anything that's glaringly wrong or gives any advice on my project. Good day! :)
@ah-nafPosted over 3 years ago- Use hover effect in links and button.
- In grid section, you are displaying images in wrong order on mobile version. You can use order property to fix that.
In spite of that, everything looks great.
Marked as helpful1 - @futuregitSubmitted over 3 years ago
Greeting. Please provide feedback on the design. With your permission, I would like to add the best responses to my portfolio and freelance sites. Thank you in advance.
Here are some questions:
-
Did the design match closely to the challenge?
-
How did you like the design for mobile screens?
-
Did the design look professional?
@ah-nafPosted over 3 years ago1.use margin auto for hero and and feature container in desktop version. 2.Also add some margin or padding in navbar. 3.It would be great to use max-width / min -width in some paragraphs.
Marked as helpful1 -
- @Paulo-EmerencioSubmitted over 3 years ago
Is there something wrong with this mixin:
@mixin responsive($property, $size) { @media ($property: $size) { @content } }
It worked as expected, but VsCode refuses to put the variable color on the $property in the second line, and github also let it unpainted.
@ah-nafPosted over 3 years agoTry this.
@mixin responsive($property, $size) { @media (#{$property}: $size) { @content } }
You can also check the documentation for more.
Marked as helpful1 - @sanketcharanpahadiSubmitted over 3 years ago
feedbacks would be appreciated on the use of media queries . How can I use it more effectively ?
@ah-nafPosted over 3 years agoIncrease the height of about and image class. Change the max width of media query to 768px. It might look good.
Marked as helpful0 - @tttinhSubmitted over 3 years ago
Hi everyone,
Hope you have a good day. I'd like to hear feedback from you for this solution.
Thanks.
- @SaifN97Submitted over 3 years ago
Constructive feedbacks are welcome : )
- @NataliaTgSubmitted over 3 years ago
Hi! I would like to get some feedback about my challenge. What do you think about it? It's all ok? Hug! :)