Skip to content
Submitted over 3 years ago

VS Code, CSS and HTML

futuregit•70
@futuregit
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Fylo dark theme landing page
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

Greeting. Please provide feedback on the design. With your permission, I would like to add the best responses to my portfolio and freelance sites. Thank you in advance.

Here are some questions:

  1. Did the design match closely to the challenge?

  2. How did you like the design for mobile screens?

  3. Did the design look professional?

Community feedback

  • Ahmed Faisal•5,095
    @afrusselPosted over 3 years ago

    Hi, main container is not center aligned.

    Marked as helpful
    2
  • Chamu•13,130
    @ChamuMutezvaPosted over 3 years ago
    • input elements like the one below must be associated with a label.
      <input type="email" placeholder="[email protected]">
      <a href="#" class="email-sign-up__btn">Get Started For Free</a>
    • since the input is a form element , the a tag should not be used in this instance. You need an element for submitting a form - a button.
    • the .container has been set to a max-width of 1200px, on my desktop on the right there is a dark blue shade caused by the fact that the container is not occupying the available space.
    Marked as helpful
    1
  • Ahnaf Hasan Shifat•385
    @ah-nafPosted over 3 years ago

    1.use margin auto for hero and and feature container in desktop version. 2.Also add some margin or padding in navbar. 3.It would be great to use max-width / min -width in some paragraphs.

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord