sunnyside using react & sass

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 3 years ago

  Things that needs addressing are as follows:

  • this <img src={burger} alt="burger" onClick={() => setMenuOPen(prev => !prev)}/>, is acting as you menu to control the opening and closing the modal on mobile. Nicely done it is working, but now an image is not an interactive element and users who rely on assistive technology will not be able to know that the image is representing a button. You can either make the image a child of a button or see what aria attributes you have to add.
  • the list items are supposed to be anchor elements as they are supposed to be links to external pages.
  • write your content in lowercase and use css to uppercase it , accordingly <li className="lastli">CONTACT</li> . That won't work well with screen readers.
  • headings are important in a site , you need to check your html structure again for elements that are suitable for headings - a handful of them are currently divs. Do not use divs if there is a proper element that can do the job. As an example, the following element should be your h1

    <div className="slogan" >
            WE ARE CREATIVES
          </div>
  

  Happy coding

  Marked as helpful

  1
• 

  Ahnaf Hasan Shifat•385

  @ah-nafPosted over 3 years ago

  1. Use hover effect in links and button.
  2. In grid section, you are displaying images in wrong order on mobile version. You can use order property to fix that.

  In spite of that, everything looks great.

  Marked as helpful

  1