Skip to content
OverviewSolutions
4
Comments
6
P
Zak Schenck
@ZakSchenck

All comments

  • Zak Schenck•40
    @ZakSchenckPosted over 2 years ago

    A quick suggestion I have is to make it so when there's 0 items selected, you can't add the item to your cart. I am able to add 0 items to cart. Also I sort of broke the site by "spam adding" items to cart. It made the cart dropdown much longer than the window height. To fix this you could maybe add overflow-y: scroll; to it. Hope these helped. Good job.

    0
  • Zak Schenck•40
    @ZakSchenckPosted over 2 years ago

    Hey this is good! The only thing I'd recommend adding is validation. What I mean is that I broke the website by typing a ton of letters. So maybe add a maximum character limit? Also would be nice if it checked whether the input was empty. I was able to add empty Todo's, which is something that I noticed. Besides that, great work.

    0
  • Zak Schenck•40
    @ZakSchenckPosted over 2 years ago

    Best one I've seen so far. Mind if I try to do something similar to this as well?

    0
  • opeyemil•10
    @opeyemilSubmitted over 2 years ago

    it was lovely working on real life project

    html and css

    2
    Zak Schenck•40
    @ZakSchenckPosted over 2 years ago

    Good job dude! Would you like any feedback?

    0
  • Eddy•60
    @EddyBessSubmitted over 2 years ago

    I am still working on the mobile version , but any advice the projet or my code is welcome.

    E-Comerce Page

    1
    Zak Schenck•40
    @ZakSchenckPosted over 2 years ago

    Hey @EddyBess ! Good job so far. I have a few tips from a design/functionality standpoint. First, when I click on your cart, I'm unable to toggle the menu to close it. You can set a toggle classlist to the cart icon and easily add that. Alternatively, you can add an X button on it which is even better. I'd also add more spacing between the Nav Items, as well as the item counter. Makes the site less cluttered and have a better feel. The last suggestion I have which is the least important since you have an X button: In your lightbox it's always a good touch to be able to click anywhere on the page to get rid of your lightbox. In this instance, clicking on the black opacity background.

    Again, good job man. I hope these were helpful in some way. Cheers!

    0
  • Zak Schenck•40
    @ZakSchenckPosted over 2 years ago

    @TheCoderGuru gave excellent feedback, but I'd like to also suggest adding a notification for when the cart has items in it. I would have never known it had items in it until I checked. I did this by adding a container for the cart image and notification, then setting the position of the notification to absolute and positioned it to my liking. There are more way to do it though.

    Marked as helpful
    0